[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1423-g9271dc5

Volker Lendecke vlendec at samba.org
Sun May 3 21:05:51 GMT 2009


The branch, master has been updated
       via  9271dc5f7eb3e18021e27f334837d28b921db8e5 (commit)
      from  2fe79f75847d43a626f64229366a44373a11e7b3 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 9271dc5f7eb3e18021e27f334837d28b921db8e5
Author: Volker Lendecke <vl at samba.org>
Date:   Sun May 3 23:05:11 2009 +0200

    Fix Coverity ID 913 (NEGATIVE_RETURNS) -- gd, please check!

-----------------------------------------------------------------------

Summary of changes:
 source3/libgpo/gpo_filesync.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libgpo/gpo_filesync.c b/source3/libgpo/gpo_filesync.c
index d4b623a..85323c1 100644
--- a/source3/libgpo/gpo_filesync.c
+++ b/source3/libgpo/gpo_filesync.c
@@ -40,7 +40,7 @@ NTSTATUS gpo_copy_file(TALLOC_CTX *mem_ctx,
 {
 	NTSTATUS result;
 	uint16_t fnum;
-	int fd = 0;
+	int fd = -1;
 	char *data = NULL;
 	static int io_bufsize = 64512;
 	int read_size = io_bufsize;
@@ -82,7 +82,7 @@ NTSTATUS gpo_copy_file(TALLOC_CTX *mem_ctx,
 	if (fnum) {
 		cli_close(cli, fnum);
 	}
-	if (fd) {
+	if (fd != -1) {
 		close(fd);
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list