[SCM] Samba Shared Repository - branch v3-3-test updated -
release-3-2-0pre2-5164-gc38c80f
Volker Lendecke
vlendec at samba.org
Tue Mar 24 10:58:50 GMT 2009
The branch, v3-3-test has been updated
via c38c80fcd3f63e60450fd95c27d842082e8e00fd (commit)
from deba6c883965f99bf70744a5a4fb8124a73910fd (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit c38c80fcd3f63e60450fd95c27d842082e8e00fd
Author: Volker Lendecke <vl at samba.org>
Date: Tue Mar 24 11:07:16 2009 +0100
Fix bug 6097
A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.
Thanks to Pavel <wylda at volny.cz> for the bug report!
-----------------------------------------------------------------------
Summary of changes:
source/passdb/lookup_sid.c | 2 +-
source/rpc_server/srv_lsa_nt.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/passdb/lookup_sid.c b/source/passdb/lookup_sid.c
index 2a5eacd..f4fc7b5 100644
--- a/source/passdb/lookup_sid.c
+++ b/source/passdb/lookup_sid.c
@@ -804,7 +804,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
} else {
/* This is a normal SID with rid component */
if (!sid_split_rid(&sid, &rid)) {
- result = NT_STATUS_INVALID_PARAMETER;
+ result = NT_STATUS_INVALID_SID;
goto fail;
}
}
diff --git a/source/rpc_server/srv_lsa_nt.c b/source/rpc_server/srv_lsa_nt.c
index 0176d16..f9cfeed 100644
--- a/source/rpc_server/srv_lsa_nt.c
+++ b/source/rpc_server/srv_lsa_nt.c
@@ -828,6 +828,10 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
&names,
&mapped_count);
+ if (NT_STATUS_IS_ERR(status)) {
+ return status;
+ }
+
/* Convert from lsa_TranslatedName2 to lsa_TranslatedName */
names_out = TALLOC_ARRAY(p->mem_ctx, struct lsa_TranslatedName,
num_sids);
--
Samba Shared Repository
More information about the samba-cvs
mailing list