[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-5036-g9809849

Jeremy Allison jra at samba.org
Wed Mar 4 22:49:29 GMT 2009


The branch, v3-3-test has been updated
       via  9809849d976597a0b1ed098ac5f9f353a98ca651 (commit)
      from  784a9ae6fed4169b2e21608a1963a2b9af8c47fc (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 9809849d976597a0b1ed098ac5f9f353a98ca651
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Mar 4 14:47:44 2009 -0800

    Fix crashes when running RAW-ACLs against system with tdb ACL modules
    (caused by the POSIX pathname fixes).
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/modules/vfs_acl_tdb.c   |    4 ++--
 source/modules/vfs_acl_xattr.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/modules/vfs_acl_tdb.c b/source/modules/vfs_acl_tdb.c
index 49a316a..829ac48 100644
--- a/source/modules/vfs_acl_tdb.c
+++ b/source/modules/vfs_acl_tdb.c
@@ -191,7 +191,7 @@ static NTSTATUS get_acl_blob(TALLOC_CTX *ctx,
 	if (fsp && fsp->fh->fd != -1) {
 		ret = SMB_VFS_FSTAT(fsp, &sbuf);
 	} else {
-		if (fsp->posix_open) {
+		if (fsp && fsp->posix_open) {
 			ret = SMB_VFS_LSTAT(handle->conn, name, &sbuf);
 		} else {
 			ret = SMB_VFS_STAT(handle->conn, name, &sbuf);
@@ -508,7 +508,7 @@ static NTSTATUS inherit_new_acl(vfs_handle_struct *handle,
 		if (fsp && !fsp->is_directory && fsp->fh->fd != -1) {
 			ret = SMB_VFS_FSTAT(fsp, &sbuf);
 		} else {
-			if (fsp->posix_open) {
+			if (fsp && fsp->posix_open) {
 				ret = SMB_VFS_LSTAT(handle->conn,fname, &sbuf);
 			} else {
 				ret = SMB_VFS_STAT(handle->conn,fname, &sbuf);
diff --git a/source/modules/vfs_acl_xattr.c b/source/modules/vfs_acl_xattr.c
index b12422f..958991b 100644
--- a/source/modules/vfs_acl_xattr.c
+++ b/source/modules/vfs_acl_xattr.c
@@ -384,7 +384,7 @@ static NTSTATUS inherit_new_acl(vfs_handle_struct *handle,
 		if (fsp && !fsp->is_directory && fsp->fh->fd != -1) {
 			ret = SMB_VFS_FSTAT(fsp, &sbuf);
 		} else {
-			if (fsp->posix_open) {
+			if (fsp && fsp->posix_open) {
 				ret = SMB_VFS_LSTAT(handle->conn,fname, &sbuf);
 			} else {
 				ret = SMB_VFS_STAT(handle->conn,fname, &sbuf);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list