[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-23-g1e989db

Jeremy Allison jra at samba.org
Fri Jun 19 21:56:04 GMT 2009


The branch, master has been updated
       via  1e989dbb91175a6e040117ac77bcd58fba877605 (commit)
      from  8925778a61bc26e898d948ee445eb4f9781924de (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 1e989dbb91175a6e040117ac77bcd58fba877605
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jun 19 14:55:00 2009 -0700

    Fix coverity #676. Forward NULL.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/open.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index d6331ee..72370c8 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -1463,6 +1463,12 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 		DEBUG(10, ("open_file_ntcreate: printer open fname=%s\n",
 			   smb_fname_str_dbg(smb_fname)));
 
+		if (!req) {
+			DEBUG(0,("open_file_ntcreate: printer open without "
+				"an SMB request!\n"));
+			return NT_STATUS_INTERNAL_ERROR;
+		}
+
 		return print_fsp_open(req, conn, fname, req->vuid, fsp,
 				      &smb_fname->st);
 	}


-- 
Samba Shared Repository


More information about the samba-cvs mailing list