[SCM] Samba Shared Repository - branch v3-3-test updated -
release-3-2-0pre2-5314-g7e51314
Karolin Seeger
kseeger at samba.org
Thu Jun 18 09:54:53 GMT 2009
The branch, v3-3-test has been updated
via 7e51314f2e18241876b049642fcb133df7e44c70 (commit)
from a5a31512de9d9b9ed7eed906487dd154fde7e483 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit 7e51314f2e18241876b049642fcb133df7e44c70
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jun 18 11:53:52 2009 +0200
Fix bug #6476 - more then 3000 smbd-zombies in memory
We weren't reaping children in the [x]inetd case.
Jeremy.
-----------------------------------------------------------------------
Summary of changes:
source/smbd/server.c | 19 +++++++++++++++----
1 files changed, 15 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/smbd/server.c b/source/smbd/server.c
index 2415aeb..e0f86a6 100644
--- a/source/smbd/server.c
+++ b/source/smbd/server.c
@@ -355,10 +355,6 @@ static bool open_sockets_smbd(bool is_daemon, bool interactive, const char *smb_
struct dns_reg_state * dns_reg = NULL;
unsigned dns_port = 0;
- if (!is_daemon) {
- return open_sockets_inetd();
- }
-
#ifdef HAVE_ATEXIT
{
static int atexit_set;
@@ -369,6 +365,17 @@ static bool open_sockets_smbd(bool is_daemon, bool interactive, const char *smb_
}
#endif
+ if (!is_daemon) {
+ /*
+ * Stop zombies the old way.
+ * We aren't forking any new
+ * 'normal' connections when
+ * run from [x]inetd.
+ */
+ CatchChild();
+ return open_sockets_inetd();
+ }
+
/* Stop zombies */
CatchSignal(SIGCLD, sig_cld);
@@ -1252,6 +1259,10 @@ extern void build_options(bool screen);
BlockSignals(False, SIGUSR1);
BlockSignals(False, SIGTERM);
+ /* Ensure we leave no zombies until we
+ * correctly set up child handling below. */
+ CatchChild();
+
/* we want total control over the permissions on created files,
so set our umask to 0 */
umask(0);
--
Samba Shared Repository
More information about the samba-cvs
mailing list