[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4888-g8e11901

[Jeremy Allison]

The branch, v3-3-test has been updated
       via  8e11901f92b2ecb976f0c24c5eb96fb6b8127207 (commit)
      from  61465c57b9579a6f25381a9f16bca0852ca67f75 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 8e11901f92b2ecb976f0c24c5eb96fb6b8127207
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 29 17:27:16 2009 -0800

    Fix coverity CID#115. Resource leak in error path.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/libnet/libnet_samsync_ldif.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libnet/libnet_samsync_ldif.c b/source/libnet/libnet_samsync_ldif.c
index 3068f8d..4286331 100644
--- a/source/libnet/libnet_samsync_ldif.c
+++ b/source/libnet/libnet_samsync_ldif.c
@@ -776,7 +776,10 @@ static NTSTATUS fetch_alias_info_to_ldif(TALLOC_CTX *mem_ctx,
 	g_rid = r->rid;
 	groupmap->gidNumber = ldif_gid;
 	groupmap->sambaSID = talloc_asprintf(mem_ctx, "%s-%d", sid, g_rid);
-	NT_STATUS_HAVE_NO_MEMORY(groupmap->sambaSID);
+	if (groupmap->sambaSID == NULL) {
+		SAFE_FREE(group_attr);
+		return NT_STATUS_NO_MEMORY;
+	}
 
 	/* Write the data to the temporary add ldif file */
 	fprintf(add_fd, "# %s, %s, %s\n", aliasname, group_attr,


-- 
Samba Shared Repository