[SCM] Samba Shared Repository - branch master updated -
release-4-0-0alpha6-227-g734647b
Jeremy Allison
jra at samba.org
Fri Jan 30 01:28:37 GMT 2009
The branch, master has been updated
via 734647bd85560ed02691d79c0a613543043d8625 (commit)
from 77bac5b78c10d816e02a8a407b0a4653d72868a0 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 734647bd85560ed02691d79c0a613543043d8625
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jan 29 17:27:47 2009 -0800
Fix coverity CID#115. Resource leak in error path.
Jeremy.
-----------------------------------------------------------------------
Summary of changes:
source3/libnet/libnet_samsync_ldif.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libnet/libnet_samsync_ldif.c b/source3/libnet/libnet_samsync_ldif.c
index 3068f8d..4286331 100644
--- a/source3/libnet/libnet_samsync_ldif.c
+++ b/source3/libnet/libnet_samsync_ldif.c
@@ -776,7 +776,10 @@ static NTSTATUS fetch_alias_info_to_ldif(TALLOC_CTX *mem_ctx,
g_rid = r->rid;
groupmap->gidNumber = ldif_gid;
groupmap->sambaSID = talloc_asprintf(mem_ctx, "%s-%d", sid, g_rid);
- NT_STATUS_HAVE_NO_MEMORY(groupmap->sambaSID);
+ if (groupmap->sambaSID == NULL) {
+ SAFE_FREE(group_attr);
+ return NT_STATUS_NO_MEMORY;
+ }
/* Write the data to the temporary add ldif file */
fprintf(add_fd, "# %s, %s, %s\n", aliasname, group_attr,
--
Samba Shared Repository
More information about the samba-cvs
mailing list