[SCM] Samba Shared Repository - branch v3-3-test updated -
release-3-2-0pre2-4858-gdb2d564
Jeremy Allison
jra at samba.org
Fri Jan 23 00:10:09 GMT 2009
The branch, v3-3-test has been updated
via db2d56484e21daeb91df4b5e2286d242910336e8 (commit)
from 90b660e2382711d005e8c4c4ae1c6adbd5e5b687 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit db2d56484e21daeb91df4b5e2286d242910336e8
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jan 22 16:09:26 2009 -0800
Fix logic error in try_chown - we shouldn't arbitrarily chown
to ourselves unless that was passed in.
Jeremy.
-----------------------------------------------------------------------
Summary of changes:
source/modules/vfs_aixacl2.c | 2 --
source/smbd/posix_acls.c | 15 +++++++++------
2 files changed, 9 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/modules/vfs_aixacl2.c b/source/modules/vfs_aixacl2.c
index a078b9f..5ebc3a1 100644
--- a/source/modules/vfs_aixacl2.c
+++ b/source/modules/vfs_aixacl2.c
@@ -25,8 +25,6 @@
#define AIXACL2_MODULE_NAME "aixacl2"
-extern int try_chown(connection_struct *conn, const char *fname, uid_t uid, gid_t gid);
-
extern SMB_ACL_T aixacl_to_smbacl( struct acl *file_acl);
extern struct acl *aixacl_smb_to_aixacl(SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl);
diff --git a/source/smbd/posix_acls.c b/source/smbd/posix_acls.c
index 0882cb5..b862699 100644
--- a/source/smbd/posix_acls.c
+++ b/source/smbd/posix_acls.c
@@ -3187,6 +3187,15 @@ int try_chown(connection_struct *conn, const char *fname, uid_t uid, gid_t gid)
return -1;
}
+ /* only allow chown to the current user. This is more secure,
+ and also copes with the case where the SID in a take ownership ACL is
+ a local SID on the users workstation
+ */
+ if (uid != current_user.ut.uid) {
+ errno = EPERM;
+ return -1;
+ }
+
if (SMB_VFS_STAT(conn,fname,&st)) {
return -1;
}
@@ -3195,12 +3204,6 @@ int try_chown(connection_struct *conn, const char *fname, uid_t uid, gid_t gid)
return -1;
}
- /* only allow chown to the current user. This is more secure,
- and also copes with the case where the SID in a take ownership ACL is
- a local SID on the users workstation
- */
- uid = current_user.ut.uid;
-
become_root();
/* Keep the current file gid the same. */
ret = SMB_VFS_FCHOWN(fsp, uid, (gid_t)-1);
--
Samba Shared Repository
More information about the samba-cvs
mailing list