[SCM] Samba Shared Repository - branch master updated - 1c77c7f3d5b6cb29fac4606299c237c0e299f836

[simo]

On Fri, 2009-01-16 at 19:17 -0500, Derrell Lipman wrote:
> On Fri, Jan 16, 2009 at 5:59 PM, simo <idra at samba.org> wrote:
> 
> > On Fri, 2009-01-16 at 15:42 -0600, Derrell Lipman wrote:
> > >
> > > +       /* POSIX-like - always request case-sensitivity by default.
> > > */
> > > +        if (smbc_getOptionCaseSensitive(context)) {
> > > +            cli_set_case_sensitive(c, True);
> > > +        } else {
> > > +            cli_set_case_sensitive(c, False);
> > > +        }
> > > +
> > >          if (smbc_getOptionUseKerberos(context)) {
> > >                 c->use_kerberos = True;
> > >         }
> >
> > Derrell,
> > *if* I am readying the code right, now every connection defaults to case
> > sensitive ?
> > If so I think this would break in case the server is case-insensitive.
> >
> > Shouldn't this options set to true by default only if the remote server
> > *is* case sensitive ?
> 
> 
> I can't imagine why there would be a function for specifying the case
> sensitivity (cli_set_case_sensitive) if it were possible to determine
> whether the remote server *is* case sensitive. If it is possible then the
> case-sensitive setting should be automatically configured when the
> connection is established. What am I missing here? Is there ever a time that
> you'd want case sensitive when the server is not, or vice versa?

Case sensitivity is something you can negotiate with the server.
for example samba is case insensitive normally, but case sensitive when
you negotiate unix extensions.

I think case sensitivity should be based on what has been negotiated
with the server, and not set arbitrarily.

Simo.


-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>