[SCM] Samba Shared Repository - branch master updated - b516a2abcadb4a58fe7058ddbb4e38f53a467426

Karolin Seeger kseeger at samba.org
Fri Jan 9 16:00:48 GMT 2009


The branch, master has been updated
       via  b516a2abcadb4a58fe7058ddbb4e38f53a467426 (commit)
      from  86b1b82d9ef29f0431d27d62ce2ec289078a6802 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b516a2abcadb4a58fe7058ddbb4e38f53a467426
Author: Karolin Seeger <kseeger at samba.org>
Date:   Fri Jan 9 16:52:12 2009 +0100

    s3/net: Display error message if user does not exist.
    
    net rpc rights grant: Verify if the username can be resolved to a SID and
    display a proper error message if it does not. Otherwise users might think
    setting privileges worked fine, but in fact it does not.
    
    Karolin

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/net_rpc_rights.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/net_rpc_rights.c b/source3/utils/net_rpc_rights.c
index 2bc5efe..ddcfff3 100644
--- a/source3/utils/net_rpc_rights.c
+++ b/source3/utils/net_rpc_rights.c
@@ -449,8 +449,11 @@ static NTSTATUS rpc_rights_grant_internal(struct net_context *c,
 	}
 
 	result = name_to_sid(pipe_hnd, mem_ctx, &sid, argv[0]);
+	if (NT_STATUS_EQUAL(result, NT_STATUS_NONE_MAPPED))
+		result = NT_STATUS_NO_SUCH_USER;
+
 	if (!NT_STATUS_IS_OK(result))
-		return result;
+		goto done;
 
 	result = rpccli_lsa_open_policy2(pipe_hnd, mem_ctx, true,
 				     SEC_RIGHTS_MAXIMUM_ALLOWED,


-- 
Samba Shared Repository


More information about the samba-cvs mailing list