[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4772-g5dfa403

Karolin Seeger kseeger at samba.org
Mon Jan 5 10:06:48 GMT 2009


The branch, v3-3-test has been updated
       via  5dfa403498c4f4a0eb05a5331b81326832ddd63f (commit)
      from  b8fef4ce2ed627387a22dfb5be1fa59c2e486aff (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 5dfa403498c4f4a0eb05a5331b81326832ddd63f
Author: Michael Adam <obnox at samba.org>
Date:   Thu Dec 18 18:01:55 2008 +0100

    smbd: prevent access to root filesystem when connecting with empty service name
    
    This only applies to a setup with "registry shares = yes"
    
    Michael
    (cherry picked from commit 288fa94ac7cfdf7457b5098c33fc840bed3d5410)
    (cherry picked from commit e85526b184e66f86b7faa9d0a37288a09c12c19e)

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/service.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/service.c b/source/smbd/service.c
index 0b851f1..c39584a 100644
--- a/source/smbd/service.c
+++ b/source/smbd/service.c
@@ -235,6 +235,10 @@ static int load_registry_service(const char *servicename)
 		return -1;
 	}
 
+	if ((servicename == NULL) || (*servicename == '\0')) {
+		return -1;
+	}
+
 	if (strequal(servicename, GLOBAL_NAME)) {
 		return -2;
 	}


-- 
Samba Shared Repository


More information about the samba-cvs mailing list