[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4944-g7274764

[Jeremy Allison]

The branch, v3-3-test has been updated
       via  7274764436deb21f821c7a62a3ac3454e1af9025 (commit)
      from  0697cffe211a922c816b6c75230c4186328498ed (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 7274764436deb21f821c7a62a3ac3454e1af9025
Author: Dan Sledz <dsledz at isilon.com>
Date:   Thu Feb 12 12:02:43 2009 -0800

    Fix double free caused by incorrect talloc_steal usage.

-----------------------------------------------------------------------

Summary of changes:
 source/auth/auth_util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/auth/auth_util.c b/source/auth/auth_util.c
index d2a8591..9ee19ca 100644
--- a/source/auth/auth_util.c
+++ b/source/auth/auth_util.c
@@ -573,8 +573,6 @@ NTSTATUS make_server_info_sam(auth_serversupplied_info **server_info,
 	}
 
 	result->sam_account = sampass;
-	/* Ensure thaat the sampass will be freed with the result */
-	talloc_steal(result, sampass);
 	result->unix_name = pwd->pw_name;
 	/* Ensure that we keep pwd->pw_name, because we will free pwd below */
 	talloc_steal(result, pwd->pw_name);
@@ -665,6 +663,8 @@ NTSTATUS make_server_info_sam(auth_serversupplied_info **server_info,
 		 pdb_get_username(sampass), result->unix_name));
 
 	*server_info = result;
+	/* Ensure thaat the sampass will be freed with the result */
+	talloc_steal(result, sampass);
 
 	return NT_STATUS_OK;
 }


-- 
Samba Shared Repository