[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4942-ga8a7040

[Jeremy Allison]

The branch, v3-3-test has been updated
       via  a8a7040d7dbffe7b1c2bccb8b46e08fb996786ac (commit)
      from  d1b2f90f881d554e844525ddf44232b04f14e8eb (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit a8a7040d7dbffe7b1c2bccb8b46e08fb996786ac
Author: Yasuma Takeda <yasuma at osstech.co.jp>
Date:   Wed Feb 11 14:36:51 2009 -0800

    Fix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not work correctly with "security = domain"
    
    1. If DNS server is invalid, the get_sorted_dc_list() is called with
    realm(FQDN) and it fails.
    2. On the next step, the get_sorted_dc_list() is called with realm(FQDN) again.
    
    I think "again" is wrong place.
    On the 2nd step, get_sorted_dc_list() should be called with realm(WORKGROUP).

-----------------------------------------------------------------------

Summary of changes:
 source/libads/ldap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libads/ldap.c b/source/libads/ldap.c
index a91f4ac..4fb9530 100644
--- a/source/libads/ldap.c
+++ b/source/libads/ldap.c
@@ -299,6 +299,8 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
 	if (c_realm && *c_realm)
 		got_realm = True;
 
+ again:
+
 	/* we need to try once with the realm name and fallback to the
 	   netbios domain name if we fail (if netbios has not been disabled */
 
@@ -350,8 +352,6 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
 
 	sitename = sitename_fetch(realm);
 
- again:
-
 	DEBUG(6,("ads_find_dc: (cldap) looking for %s '%s'\n",
 		(got_realm ? "realm" : "domain"), realm));
 


-- 
Samba Shared Repository