[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-673-g39172b5

Jelmer Vernooij jelmer at samba.org
Mon Feb 9 17:50:42 GMT 2009


The branch, master has been updated
       via  39172b5ce91610773ecd5f4d6b2c7b25b5dfee5d (commit)
      from  fa1ead3aa06bfccd5e62a02e6e3c88d223ed7817 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 39172b5ce91610773ecd5f4d6b2c7b25b5dfee5d
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Mon Feb 9 18:39:27 2009 +0100

    Remove an invalid discard_const_p() - it masks an actual
    bug in pidl where pidl uses "const" in a struct where there should not be
    const.
    
    There is only a single place in the Samba codebase where this triggers a
    warning.

-----------------------------------------------------------------------

Summary of changes:
 pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm b/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
index b35762f..84752da 100644
--- a/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
@@ -2173,7 +2173,7 @@ sub ParseFunctionPull($$)
 			if (grep(/in/, @{$e->{DIRECTION}})) {
 				$self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, ($size) * sizeof(*r->in.$e->{NAME}));");
 			} else {
-				$self->pidl("memset(discard_const_p(struct $fn->{NAME} *, r->out.$e->{NAME}), 0, ($size) * sizeof(*r->out.$e->{NAME}));");
+				$self->pidl("memset(r->out.$e->{NAME}, 0, ($size) * sizeof(*r->out.$e->{NAME}));");
 			}
 		} else {
 			$self->pidl("NDR_PULL_ALLOC($ndr, r->out.$e->{NAME});");


-- 
Samba Shared Repository


More information about the samba-cvs mailing list