[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4922-g3981603

Michael Adam obnox at samba.org
Mon Feb 9 13:19:24 GMT 2009


The branch, v3-3-test has been updated
       via  3981603761a1cc6fb74ff135fadf4ab3340be1c5 (commit)
       via  ca6e3ee1e52b16e88f3906dc4cf64e977e165663 (commit)
       via  bd0febbd1b390b2890df13fbfed5bf26dede658f (commit)
      from  7f6bf488fd3758f631edcade61378955cf9bf674 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 3981603761a1cc6fb74ff135fadf4ab3340be1c5
Author: Michael Adam <obnox at samba.org>
Date:   Mon Feb 9 13:50:31 2009 +0100

    s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary.
    
    Calling find_domain_from_name_noinit() might not be enough here.
    This makes winbindd_getpwent() behave the same as winbindd_getgrent().
    
    Michael
    
    Signed-off-by: Michael Adam <obnox at samba.org>

commit ca6e3ee1e52b16e88f3906dc4cf64e977e165663
Author: Michael Adam <obnox at samba.org>
Date:   Mon Feb 9 11:07:11 2009 +0100

    s3:winbindd_user: fix a debug message.
    
    find_domain_from_name_noinit() is no longer called only for
    name alias support.
    
    Michael
    
    Signed-off-by: Michael Adam <obnox at samba.org>

commit bd0febbd1b390b2890df13fbfed5bf26dede658f
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Feb 7 11:09:45 2009 +0100

    Fix coverity ID 876 (FORWARD_NULL)
    
    Michael, please check!
    
    Signed-off-by: Michael Adam <obnox at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source/winbindd/winbindd_user.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/winbindd/winbindd_user.c b/source/winbindd/winbindd_user.c
index 62fd4d7..8b481f9 100644
--- a/source/winbindd/winbindd_user.c
+++ b/source/winbindd/winbindd_user.c
@@ -80,11 +80,12 @@ static bool winbindd_fill_pwent(TALLOC_CTX *ctx, char *dom_name, char *user_name
 	if (!pw || !dom_name || !user_name)
 		return False;
 
-	domain = find_domain_from_name_noinit(dom_name);
+	domain = find_domain_from_name(dom_name);
 	if (domain == NULL) {
-		DEBUG(5,("winbindd_fill_pwent: Failed to find domain for %s.  "
-			 "Disabling name alias support\n", dom_name));
+		DEBUG(5,("winbindd_fill_pwent: Failed to find domain for %s.\n",
+			 dom_name));
 		nt_status = NT_STATUS_NO_SUCH_DOMAIN;
+		return false;
 	}
 
 	/* Resolve the uid number */


-- 
Samba Shared Repository


More information about the samba-cvs mailing list