[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-630-g8cc60bf

Günther Deschner gd at samba.org
Mon Feb 9 09:44:05 GMT 2009


The branch, master has been updated
       via  8cc60bf978e42310e3b285b43a00c509607d7078 (commit)
       via  3c1d2f2a3ae52a2dcdf03cc6814d144a29694a9c (commit)
       via  9232a5be207dc156c37f45eede0f2de6465e58ee (commit)
       via  373a4d829d4f3591b10044af38ebf2097d21e533 (commit)
       via  894d05bc41c683a47590cd237194e2b3b7ec0e67 (commit)
       via  c0e3b195c86edc7fc9a862006e258e517465b7fd (commit)
       via  9ef58a91962728c48df85c09ddabacfe9ebe2f21 (commit)
       via  c7d572a76f6269b9f6edea553bcb17d270a69500 (commit)
       via  fac7ed3df1b1fde5ca16e742bd856e4ddbf7e01f (commit)
       via  3a1f9411e588742cb2d9dbb6f8edc1b78893fbd0 (commit)
       via  5234f5e433847e6efd29e0c4a7d76a491818a92a (commit)
      from  45f142fe29059accad5ff408e844ad3ae29e3b96 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 8cc60bf978e42310e3b285b43a00c509607d7078
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 23:13:45 2009 +0100

    s3-spoolss: remove old _spoolss_GetForm.
    
    Guenther

commit 3c1d2f2a3ae52a2dcdf03cc6814d144a29694a9c
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 23:12:25 2009 +0100

    s3-spoolss: use pidl for _spoolss_GetForm.
    
    Guenther

commit 9232a5be207dc156c37f45eede0f2de6465e58ee
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 23:11:28 2009 +0100

    s3-spoolss: add fill_form_info_1.
    
    Guenther

commit 373a4d829d4f3591b10044af38ebf2097d21e533
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 19:51:20 2009 +0100

    s3-rpcclient: use rpccli_spoolss_GetForm.
    
    Guenther

commit 894d05bc41c683a47590cd237194e2b3b7ec0e67
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 19:24:39 2009 +0100

    s3-spoolss: restore delete_a_form().
    
    Guenther

commit c0e3b195c86edc7fc9a862006e258e517465b7fd
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 19:21:26 2009 +0100

    s3-spoolss: remove old _spoolss_SetForm.
    
    Guenther

commit 9ef58a91962728c48df85c09ddabacfe9ebe2f21
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 19:19:57 2009 +0100

    s3-spoolss: use pidl for _spoolss_SetForm.
    
    Guenther

commit c7d572a76f6269b9f6edea553bcb17d270a69500
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 19:19:20 2009 +0100

    s3-rpcclient: use rpccli_spoolss_SetForm.
    
    Guenther

commit fac7ed3df1b1fde5ca16e742bd856e4ddbf7e01f
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 00:04:48 2009 +0100

    s3-spoolss: remove old spoolss_AddForm.
    
    Guenther

commit 3a1f9411e588742cb2d9dbb6f8edc1b78893fbd0
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 00:04:27 2009 +0100

    s3-spoolss: use pidl for spoolss_AddForm.
    
    Guenther

commit 5234f5e433847e6efd29e0c4a7d76a491818a92a
Author: Günther Deschner <gd at samba.org>
Date:   Sun Feb 8 00:03:00 2009 +0100

    s3-spoolss: use rpccli_spoolss_AddForm in net and rpcclient.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source3/include/proto.h             |   31 +----
 source3/include/rpc_spoolss.h       |   49 -------
 source3/printing/nt_printing.c      |   61 ++++------
 source3/rpc_client/cli_spoolss.c    |  107 ----------------
 source3/rpc_parse/parse_spoolss.c   |  239 -----------------------------------
 source3/rpc_server/srv_spoolss.c    |   66 +---------
 source3/rpc_server/srv_spoolss_nt.c |  155 +++++++++++------------
 source3/rpcclient/cmd_spoolss.c     |  111 ++++++++++++----
 source3/utils/net_rpc_printer.c     |   28 +++--
 9 files changed, 205 insertions(+), 642 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/include/proto.h b/source3/include/proto.h
index 6988788..f10152f 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -4791,10 +4791,9 @@ bool get_a_builtin_ntform(UNISTR2 *uni_formname,nt_forms_struct *form);
 bool get_a_builtin_ntform_by_string(const char *form_name, nt_forms_struct *form);
 int get_ntforms(nt_forms_struct **list);
 int write_ntforms(nt_forms_struct **list, int number);
-bool add_a_form(nt_forms_struct **list, const FORM *form, int *count);
-bool delete_a_form(nt_forms_struct **list, UNISTR2 *del_name, int *count, WERROR *ret);
-bool delete_a_form_by_string(nt_forms_struct **list, const char *del_name, int *count, WERROR *ret);
-void update_a_form(nt_forms_struct **list, const FORM *form, int count);
+bool add_a_form(nt_forms_struct **list, struct spoolss_AddFormInfo1 *form, int *count);
+bool delete_a_form(nt_forms_struct **list, const char *del_name, int *count, WERROR *ret);
+void update_a_form(nt_forms_struct **list, struct spoolss_AddFormInfo1 *form, int count);
 int get_ntdrivers(fstring **list, const char *architecture, uint32 version);
 const char *get_short_archi(const char *long_archi);
 WERROR clean_up_driver_struct(struct pipes_struct *rpc_pipe,
@@ -5469,14 +5468,6 @@ WERROR rpccli_spoolss_getprintprocessordirectory(struct rpc_pipe_client *cli,
 					      TALLOC_CTX *mem_ctx,
 					      char *name, char *environment,
 					      fstring procdir);
-WERROR rpccli_spoolss_addform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
-			   POLICY_HND *handle, uint32 level, FORM *form);
-WERROR rpccli_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
-			   POLICY_HND *handle, uint32 level, 
-			   const char *form_name, FORM *form);
-WERROR rpccli_spoolss_getform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
-			   POLICY_HND *handle, const char *formname, 
-			   uint32 level, FORM_1 *form);
 WERROR rpccli_spoolss_enumforms(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
 			     POLICY_HND *handle, int level, uint32 *num_forms,
 			     FORM_1 **forms);
@@ -5990,8 +5981,6 @@ bool make_spoolss_q_enumprinterdrivers(SPOOL_Q_ENUMPRINTERDRIVERS *q_u,
 bool spoolss_io_q_enumprinterdrivers(const char *desc, SPOOL_Q_ENUMPRINTERDRIVERS *q_u, prs_struct *ps, int depth);
 bool spoolss_io_q_enumforms(const char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps, int depth);
 bool spoolss_io_r_enumforms(const char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *ps, int depth);
-bool spoolss_io_q_getform(const char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int depth);
-bool spoolss_io_r_getform(const char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps, int depth);
 bool spoolss_io_r_enumports(const char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *ps, int depth);
 bool spoolss_io_q_enumports(const char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps, int depth);
 bool spool_io_printer_info_level_1(const char *desc, SPOOL_PRINTER_INFO_LEVEL_1 *il, prs_struct *ps, int depth);
@@ -6055,10 +6044,6 @@ bool spoolss_io_q_setprinterdata(const char *desc, SPOOL_Q_SETPRINTERDATA *q_u,
 bool spoolss_io_r_setprinterdata(const char *desc, SPOOL_R_SETPRINTERDATA *r_u, prs_struct *ps, int depth);
 bool spoolss_io_q_resetprinter(const char *desc, SPOOL_Q_RESETPRINTER *q_u, prs_struct *ps, int depth);
 bool spoolss_io_r_resetprinter(const char *desc, SPOOL_R_RESETPRINTER *r_u, prs_struct *ps, int depth);
-bool spoolss_io_q_addform(const char *desc, SPOOL_Q_ADDFORM *q_u, prs_struct *ps, int depth);
-bool spoolss_io_r_addform(const char *desc, SPOOL_R_ADDFORM *r_u, prs_struct *ps, int depth);
-bool spoolss_io_q_setform(const char *desc, SPOOL_Q_SETFORM *q_u, prs_struct *ps, int depth);
-bool spoolss_io_r_setform(const char *desc, SPOOL_R_SETFORM *r_u, prs_struct *ps, int depth);
 bool spoolss_io_r_getjob(const char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int depth);
 bool spoolss_io_q_getjob(const char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int depth);
 void free_devmode(DEVICEMODE *devmode);
@@ -6105,13 +6090,6 @@ bool make_spoolss_q_getprintprocessordirectory(SPOOL_Q_GETPRINTPROCESSORDIRECTOR
 bool spoolss_io_q_getprintprocessordirectory(const char *desc, SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, prs_struct *ps, int depth);
 bool spoolss_io_r_getprintprocessordirectory(const char *desc, SPOOL_R_GETPRINTPROCESSORDIRECTORY *r_u, prs_struct *ps, int depth);
 bool smb_io_printprocessordirectory_1(const char *desc, RPC_BUFFER *buffer, PRINTPROCESSOR_DIRECTORY_1 *info, int depth);
-bool make_spoolss_q_addform(SPOOL_Q_ADDFORM *q_u, POLICY_HND *handle, 
-			    int level, FORM *form);
-bool make_spoolss_q_setform(SPOOL_Q_SETFORM *q_u, POLICY_HND *handle, 
-			    int level, const char *form_name, FORM *form);
-bool make_spoolss_q_getform(SPOOL_Q_GETFORM *q_u, POLICY_HND *handle, 
-                            const char *formname, uint32 level, 
-			    RPC_BUFFER *buffer, uint32 offered);
 bool make_spoolss_q_enumforms(SPOOL_Q_ENUMFORMS *q_u, POLICY_HND *handle, 
 			      uint32 level, RPC_BUFFER *buffer,
 			      uint32 offered);
@@ -6348,7 +6326,6 @@ WERROR _spoolss_schedulejob( pipes_struct *p, SPOOL_Q_SCHEDULEJOB *q_u, SPOOL_R_
 WERROR _spoolss_setjob(pipes_struct *p, SPOOL_Q_SETJOB *q_u, SPOOL_R_SETJOB *r_u);
 WERROR _spoolss_enumprinterdrivers( pipes_struct *p, SPOOL_Q_ENUMPRINTERDRIVERS *q_u, SPOOL_R_ENUMPRINTERDRIVERS *r_u);
 WERROR _spoolss_enumforms(pipes_struct *p, SPOOL_Q_ENUMFORMS *q_u, SPOOL_R_ENUMFORMS *r_u);
-WERROR _spoolss_getform(pipes_struct *p, SPOOL_Q_GETFORM *q_u, SPOOL_R_GETFORM *r_u);
 WERROR enumports_hook(TALLOC_CTX *ctx, int *count, char ***lines );
 WERROR _spoolss_enumports( pipes_struct *p, SPOOL_Q_ENUMPORTS *q_u, SPOOL_R_ENUMPORTS *r_u);
 WERROR _spoolss_addprinterex( pipes_struct *p, SPOOL_Q_ADDPRINTEREX *q_u, SPOOL_R_ADDPRINTEREX *r_u);
@@ -6359,8 +6336,6 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
 WERROR _spoolss_setprinterdata( pipes_struct *p, SPOOL_Q_SETPRINTERDATA *q_u, SPOOL_R_SETPRINTERDATA *r_u);
 WERROR _spoolss_resetprinter(pipes_struct *p, SPOOL_Q_RESETPRINTER *q_u, SPOOL_R_RESETPRINTER *r_u);
 WERROR _spoolss_deleteprinterdata(pipes_struct *p, SPOOL_Q_DELETEPRINTERDATA *q_u, SPOOL_R_DELETEPRINTERDATA *r_u);
-WERROR _spoolss_addform( pipes_struct *p, SPOOL_Q_ADDFORM *q_u, SPOOL_R_ADDFORM *r_u);
-WERROR _spoolss_setform(pipes_struct *p, SPOOL_Q_SETFORM *q_u, SPOOL_R_SETFORM *r_u);
 WERROR _spoolss_enumprintprocessors(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCESSORS *q_u, SPOOL_R_ENUMPRINTPROCESSORS *r_u);
 WERROR _spoolss_enumprintprocdatatypes(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCDATATYPES *q_u, SPOOL_R_ENUMPRINTPROCDATATYPES *r_u);
 WERROR _spoolss_enumprintmonitors(pipes_struct *p, SPOOL_Q_ENUMPRINTMONITORS *q_u, SPOOL_R_ENUMPRINTMONITORS *r_u);
diff --git a/source3/include/rpc_spoolss.h b/source3/include/rpc_spoolss.h
index 6655635..b1debb8 100644
--- a/source3/include/rpc_spoolss.h
+++ b/source3/include/rpc_spoolss.h
@@ -1263,24 +1263,6 @@ typedef struct spool_r_enumforms
 }
 SPOOL_R_ENUMFORMS;
 
-typedef struct spool_q_getform
-{
-	POLICY_HND handle;
-	UNISTR2 formname;
-	uint32 level;
-	RPC_BUFFER *buffer;
-	uint32 offered;
-}
-SPOOL_Q_GETFORM;
-
-typedef struct spool_r_getform
-{
-	RPC_BUFFER *buffer;
-	uint32 needed;
-	WERROR status;
-}
-SPOOL_R_GETFORM;
-
 typedef struct spool_printer_info_level_1
 {
 	uint32 flags;
@@ -1708,37 +1690,6 @@ typedef struct _form
 }
 FORM;
 
-typedef struct spool_q_addform
-{
-	POLICY_HND handle;
-	uint32 level;
-	uint32 level2;		/* This should really be part of the FORM structure */
-	FORM form;
-}
-SPOOL_Q_ADDFORM;
-
-typedef struct spool_r_addform
-{
-	WERROR status;
-}
-SPOOL_R_ADDFORM;
-
-typedef struct spool_q_setform
-{
-	POLICY_HND handle;
-	UNISTR2 name;
-	uint32 level;
-	uint32 level2;
-	FORM form;
-}
-SPOOL_Q_SETFORM;
-
-typedef struct spool_r_setform
-{
-	WERROR status;
-}
-SPOOL_R_SETFORM;
-
 typedef struct spool_q_getjob
 {
 	POLICY_HND handle;
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index da31945..0ed32d9 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -893,11 +893,10 @@ int write_ntforms(nt_forms_struct **list, int number)
 /****************************************************************************
 add a form struct at the end of the list
 ****************************************************************************/
-bool add_a_form(nt_forms_struct **list, const FORM *form, int *count)
+bool add_a_form(nt_forms_struct **list, struct spoolss_AddFormInfo1 *form, int *count)
 {
 	int n=0;
 	bool update;
-	fstring form_name;
 
 	/*
 	 * NT tries to add forms even when
@@ -906,10 +905,9 @@ bool add_a_form(nt_forms_struct **list, const FORM *form, int *count)
 	 */
 
 	update=False;
-	
-	unistr2_to_ascii(form_name, &form->name, sizeof(form_name));
+
 	for (n=0; n<*count; n++) {
-		if ( strequal((*list)[n].name, form_name) ) {
+		if ( strequal((*list)[n].name, form->form_name) ) {
 			update=True;
 			break;
 		}
@@ -920,20 +918,20 @@ bool add_a_form(nt_forms_struct **list, const FORM *form, int *count)
 			DEBUG(0,("add_a_form: failed to enlarge forms list!\n"));
 			return False;
 		}
-		unistr2_to_ascii((*list)[n].name, &form->name, sizeof((*list)[n].name));
+		fstrcpy((*list)[n].name, form->form_name);
 		(*count)++;
 	}
-	
-	(*list)[n].flag=form->flags;
-	(*list)[n].width=form->size_x;
-	(*list)[n].length=form->size_y;
-	(*list)[n].left=form->left;
-	(*list)[n].top=form->top;
-	(*list)[n].right=form->right;
-	(*list)[n].bottom=form->bottom;
+
+	(*list)[n].flag		= form->flags;
+	(*list)[n].width	= form->size.width;
+	(*list)[n].length	= form->size.height;
+	(*list)[n].left		= form->area.left;
+	(*list)[n].top		= form->area.top;
+	(*list)[n].right	= form->area.right;
+	(*list)[n].bottom	= form->area.bottom;
 
 	DEBUG(6,("add_a_form: Successfully %s form [%s]\n", 
-		update ? "updated" : "added", form_name));
+		update ? "updated" : "added", form->form_name));
 
 	return True;
 }
@@ -942,7 +940,7 @@ bool add_a_form(nt_forms_struct **list, const FORM *form, int *count)
  Delete a named form struct.
 ****************************************************************************/
 
-bool delete_a_form_by_string(nt_forms_struct **list, const char *del_name, int *count, WERROR *ret)
+bool delete_a_form(nt_forms_struct **list, const char *del_name, int *count, WERROR *ret)
 {
 	char *key = NULL;
 	int n=0;
@@ -975,41 +973,30 @@ bool delete_a_form_by_string(nt_forms_struct **list, const char *del_name, int *
 	return true;
 }
 
-bool delete_a_form(nt_forms_struct **list, UNISTR2 *del_name, int *count, WERROR *ret)
-{
-	fstring form_name;
-
-	unistr2_to_ascii(form_name, del_name, sizeof(form_name));
-
-	return delete_a_form_by_string(list, form_name, count, ret);
-}
-
 /****************************************************************************
  Update a form struct.
 ****************************************************************************/
 
-void update_a_form(nt_forms_struct **list, const FORM *form, int count)
+void update_a_form(nt_forms_struct **list, struct spoolss_AddFormInfo1 *form, int count)
 {
 	int n=0;
-	fstring form_name;
-	unistr2_to_ascii(form_name, &(form->name), sizeof(form_name));
 
-	DEBUG(106, ("[%s]\n", form_name));
+	DEBUG(106, ("[%s]\n", form->form_name));
 	for (n=0; n<count; n++) {
 		DEBUGADD(106, ("n [%d]:[%s]\n", n, (*list)[n].name));
-		if (!strncmp((*list)[n].name, form_name, strlen(form_name)))
+		if (!strncmp((*list)[n].name, form->form_name, strlen(form->form_name)))
 			break;
 	}
 
 	if (n==count) return;
 
-	(*list)[n].flag=form->flags;
-	(*list)[n].width=form->size_x;
-	(*list)[n].length=form->size_y;
-	(*list)[n].left=form->left;
-	(*list)[n].top=form->top;
-	(*list)[n].right=form->right;
-	(*list)[n].bottom=form->bottom;
+	(*list)[n].flag		= form->flags;
+	(*list)[n].width	= form->size.width;
+	(*list)[n].length	= form->size.height;
+	(*list)[n].left		= form->area.left;
+	(*list)[n].top		= form->area.top;
+	(*list)[n].right	= form->area.right;
+	(*list)[n].bottom	= form->area.bottom;
 }
 
 /****************************************************************************
diff --git a/source3/rpc_client/cli_spoolss.c b/source3/rpc_client/cli_spoolss.c
index bdb48a4..811301e 100644
--- a/source3/rpc_client/cli_spoolss.c
+++ b/source3/rpc_client/cli_spoolss.c
@@ -1154,113 +1154,6 @@ WERROR rpccli_spoolss_getprintprocessordirectory(struct rpc_pipe_client *cli,
 /**********************************************************************
 **********************************************************************/
 
-WERROR rpccli_spoolss_addform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
-			   POLICY_HND *handle, uint32 level, FORM *form)
-{
-	prs_struct qbuf, rbuf;
-	SPOOL_Q_ADDFORM in;
-	SPOOL_R_ADDFORM out;
-
-	ZERO_STRUCT(in);
-	ZERO_STRUCT(out);
-
-        make_spoolss_q_addform( &in, handle, level, form );
-	
-	CLI_DO_RPC_WERR( cli, mem_ctx, &syntax_spoolss, SPOOLSS_ADDFORM,
-	            in, out, 
-	            qbuf, rbuf,
-	            spoolss_io_q_addform,
-	            spoolss_io_r_addform, 
-	            WERR_GENERAL_FAILURE );
-
-	return out.status;
-}
-
-/**********************************************************************
-**********************************************************************/
-
-WERROR rpccli_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
-			   POLICY_HND *handle, uint32 level, 
-			   const char *form_name, FORM *form)
-{
-	prs_struct qbuf, rbuf;
-	SPOOL_Q_SETFORM in;
-	SPOOL_R_SETFORM out;
-
-	ZERO_STRUCT(in);
-	ZERO_STRUCT(out);
-
-        make_spoolss_q_setform( &in, handle, level, form_name, form );
-	
-	CLI_DO_RPC_WERR( cli, mem_ctx, &syntax_spoolss, SPOOLSS_SETFORM,
-	            in, out, 
-	            qbuf, rbuf,
-	            spoolss_io_q_setform,
-	            spoolss_io_r_setform, 
-	            WERR_GENERAL_FAILURE );
-
-	return out.status;
-}
-
-/**********************************************************************
-**********************************************************************/
-
-WERROR rpccli_spoolss_getform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
-			   POLICY_HND *handle, const char *formname, 
-			   uint32 level, FORM_1 *form)
-{
-	prs_struct qbuf, rbuf;
-	SPOOL_Q_GETFORM in;
-	SPOOL_R_GETFORM out;
-	RPC_BUFFER buffer;
-	uint32 offered;
-
-	ZERO_STRUCT(in);
-	ZERO_STRUCT(out);
-
-	offered = 0;
-	if (!rpcbuf_init(&buffer, offered, mem_ctx))
-		return WERR_NOMEM;
-	make_spoolss_q_getform( &in, handle, formname, level, &buffer, offered );
-	
-	CLI_DO_RPC_WERR( cli, mem_ctx, &syntax_spoolss, SPOOLSS_GETFORM,
-	            in, out, 
-	            qbuf, rbuf,
-	            spoolss_io_q_getform,
-	            spoolss_io_r_getform, 
-	            WERR_GENERAL_FAILURE );
-		    
-	if ( W_ERROR_EQUAL( out.status, WERR_INSUFFICIENT_BUFFER ) ) {
-		offered = out.needed;
-		
-		ZERO_STRUCT(in);
-		ZERO_STRUCT(out);
-		
-		if (!rpcbuf_init(&buffer, offered, mem_ctx))
-			return WERR_NOMEM;
-		make_spoolss_q_getform( &in, handle, formname, level, &buffer, offered );
-	
-		CLI_DO_RPC_WERR( cli, mem_ctx, &syntax_spoolss, SPOOLSS_GETFORM,
-		            in, out, 
-		            qbuf, rbuf,
-		            spoolss_io_q_getform,
-		            spoolss_io_r_getform, 
-		            WERR_GENERAL_FAILURE );
-	}
-	
-	if (!W_ERROR_IS_OK(out.status))
-		return out.status;
-
-	if (!smb_io_form_1("", out.buffer, form, 0)) {
-		return WERR_GENERAL_FAILURE;
-	}
-
-	return out.status;
-}
-
-/**********************************************************************
-**********************************************************************/
-
 WERROR rpccli_spoolss_enumforms(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
 			     POLICY_HND *handle, int level, uint32 *num_forms,
 			     FORM_1 **forms)
diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index 815b1b6..3fe9a30 100644
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -4094,65 +4094,6 @@ bool spoolss_io_r_enumforms(const char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct
 }
 
 /*******************************************************************
-********************************************************************/  
-
-bool spoolss_io_q_getform(const char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int depth)
-{
-
-	prs_debug(ps, depth, desc, "spoolss_io_q_getform");
-	depth++;
-
-	if (!prs_align(ps))
-		return False;			
-	if (!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
-		return False;		
-	if (!smb_io_unistr2("", &q_u->formname,True,ps,depth))
-		return False;
-
-	if (!prs_align(ps))
-		return False;
-
-	if (!prs_uint32("level", ps, depth, &q_u->level))
-		return False;	
-	
-	if (!prs_rpcbuffer_p("", ps, depth, &q_u->buffer))
-		return False;
-
-	if (!prs_align(ps))
-		return False;
-	if (!prs_uint32("offered", ps, depth, &q_u->offered))
-		return False;
-
-	return True;
-}
-
-/*******************************************************************
-********************************************************************/  
-
-bool spoolss_io_r_getform(const char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps, int depth)
-{
-	prs_debug(ps, depth, desc, "spoolss_io_r_getform");
-	depth++;
-
-	if (!prs_align(ps))
-		return False;
-		
-	if (!prs_rpcbuffer_p("", ps, depth, &r_u->buffer))
-		return False;
-
-	if (!prs_align(ps))
-		return False;
-		
-	if (!prs_uint32("size of buffer needed", ps, depth, &r_u->needed))
-		return False;
-		
-	if (!prs_werror("status", ps, depth, &r_u->status))
-		return False;
-
-	return True;
-}
-
-/*******************************************************************
  Parse a SPOOL_R_ENUMPORTS structure.
 ********************************************************************/  
 
@@ -5783,138 +5724,6 @@ bool spoolss_io_r_resetprinter(const char *desc, SPOOL_R_RESETPRINTER *r_u, prs_
 }
 
 /*******************************************************************
-********************************************************************/  
-
-static bool spoolss_io_addform(const char *desc, FORM *f, uint32 ptr, prs_struct *ps, int depth)
-{
-	prs_debug(ps, depth, desc, "spoolss_io_addform");
-	depth++;
-	if(!prs_align(ps))
-		return False;
-
-	if (ptr!=0)
-	{
-		if(!prs_uint32("flags",    ps, depth, &f->flags))
-			return False;
-		if(!prs_uint32("name_ptr", ps, depth, &f->name_ptr))
-			return False;
-		if(!prs_uint32("size_x",   ps, depth, &f->size_x))
-			return False;
-		if(!prs_uint32("size_y",   ps, depth, &f->size_y))
-			return False;
-		if(!prs_uint32("left",     ps, depth, &f->left))
-			return False;
-		if(!prs_uint32("top",      ps, depth, &f->top))
-			return False;
-		if(!prs_uint32("right",    ps, depth, &f->right))
-			return False;
-		if(!prs_uint32("bottom",   ps, depth, &f->bottom))
-			return False;
-
-		if(!smb_io_unistr2("", &f->name, f->name_ptr, ps, depth))
-			return False;
-	}
-
-	return True;
-}
-


-- 
Samba Shared Repository


More information about the samba-cvs mailing list