[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-976-g5c3cf58

[Andrew Bartlett]

The branch, master has been updated
       via  5c3cf58a842a8ddd5dca785bf5464e0788003400 (commit)
      from  88fd98b7c4ed41ab6c6ac5a226581e862ae900f3 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 5c3cf58a842a8ddd5dca785bf5464e0788003400
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 14 12:48:10 2009 +1000

    s4:ldap_server Don't talloc_steal (with references) in ldap_backend
    
    There may or may not be a need to take a reference to the 'name' in
    the ldb_map code, but given we seal the whole msg just above here, it
    makes no senst to steal the name, but not the values.
    
    Andrew Bartlett

-----------------------------------------------------------------------

Summary of changes:
 source4/ldap_server/ldap_backend.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/ldap_server/ldap_backend.c b/source4/ldap_server/ldap_backend.c
index 67cc893..d479ff8 100644
--- a/source4/ldap_server/ldap_backend.c
+++ b/source4/ldap_server/ldap_backend.c
@@ -419,7 +419,7 @@ static NTSTATUS ldapsrv_SearchRequest(struct ldapsrv_call *call)
 			ent->attributes = talloc_array(ent_r, struct ldb_message_element, ent->num_attributes);
 			NT_STATUS_HAVE_NO_MEMORY(ent->attributes);
 			for (j=0; j < ent->num_attributes; j++) {
-				ent->attributes[j].name = talloc_steal(ent->attributes, res->msgs[i]->elements[j].name);
+				ent->attributes[j].name = res->msgs[i]->elements[j].name;
 				ent->attributes[j].num_values = 0;
 				ent->attributes[j].values = NULL;
 				if (req->attributesonly && (res->msgs[i]->elements[j].num_values == 0)) {


-- 
Samba Shared Repository