[SCM] Samba Shared Repository - branch master updated -
release-4-0-0alpha7-1235-g6610327
Jeremy Allison
jra at samba.org
Thu Apr 23 09:03:49 GMT 2009
The branch, master has been updated
via 6610327770f3e7dd3e7a9b71d34b82f1f198a8a4 (commit)
from 951de687216b13e35876325e7b3c8081ea725dc8 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 6610327770f3e7dd3e7a9b71d34b82f1f198a8a4
Author: Jeremy Allison <jra at samba.org>
Date: Thu Apr 23 02:02:28 2009 -0700
Fix Coverity bug #902, uninitialized variable.
Jeremy.
-----------------------------------------------------------------------
Summary of changes:
source3/nmbd/nmbd_packets.c | 4 +++-
source3/nmbd/nmbd_processlogon.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/nmbd/nmbd_packets.c b/source3/nmbd/nmbd_packets.c
index f69845b..4045184 100644
--- a/source3/nmbd/nmbd_packets.c
+++ b/source3/nmbd/nmbd_packets.c
@@ -1936,7 +1936,9 @@ bool send_mailslot(bool unique, const char *mailslot,char *buf, size_t len,
DEBUG(0, ("send_mailslot: Cannot write beyond end of packet\n"));
return False;
} else {
- memcpy(p2,buf,len);
+ if (len) {
+ memcpy(p2,buf,len);
+ }
p2 += len;
}
diff --git a/source3/nmbd/nmbd_processlogon.c b/source3/nmbd/nmbd_processlogon.c
index 8173337..43e80af 100644
--- a/source3/nmbd/nmbd_processlogon.c
+++ b/source3/nmbd/nmbd_processlogon.c
@@ -267,7 +267,7 @@ static void nmbd_proxy_logon_done(struct tevent_req *subreq)
tevent_req_callback_data(subreq,
struct nmbd_proxy_logon_state);
NTSTATUS status;
- DATA_BLOB response;
+ DATA_BLOB response = data_blob_null;
status = cldap_netlogon_recv(subreq, NULL, state, &state->io);
if (!NT_STATUS_IS_OK(status)) {
--
Samba Shared Repository
More information about the samba-cvs
mailing list