[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3541-g51ecc77

[Volker Lendecke]

The branch, v3-2-test has been updated
       via  51ecc77eeabe5fc89e4d1b1fb8a15c71614d4049 (commit)
      from  5b43fff78081541f642b07a70b03c6d5902e42dd (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 51ecc77eeabe5fc89e4d1b1fb8a15c71614d4049
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Mar 28 19:58:45 2009 +0100

    Fix smbd crash for close_on_completion
    
    handle_trans() can talloc_free "conn" if the client requests
    close_on_completion. "state" is a talloc_child of conn, so it will be gone when
    we later free state->data et al.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/ipc.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/ipc.c b/source/smbd/ipc.c
index a53bc5b..8e40c30 100644
--- a/source/smbd/ipc.c
+++ b/source/smbd/ipc.c
@@ -658,6 +658,8 @@ void reply_trans(struct smb_request *req)
 		return;
 	}
 
+	talloc_steal(talloc_tos(), state);
+
 	handle_trans(conn, req, state);
 
 	SAFE_FREE(state->data);
@@ -787,6 +789,8 @@ void reply_transs(struct smb_request *req)
          */
         SCVAL(req->inbuf,smb_com,SMBtrans);
 
+	talloc_steal(talloc_tos(), state);
+
 	handle_trans(conn, req, state);
 
 	DLIST_REMOVE(conn->pending_trans, state);


-- 
Samba Shared Repository