[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-649-ge9457c5

[Volker Lendecke]

The branch, v3-4-test has been updated
       via  e9457c598e25ededb48b73d7dc5ab0f6295ea399 (commit)
      from  eae62459dc6fd0041a4f69601be5354f06022268 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test


- Log -----------------------------------------------------------------
commit e9457c598e25ededb48b73d7dc5ab0f6295ea399
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Mar 28 19:58:45 2009 +0100

    Fix smbd crash for close_on_completion
    
    handle_trans() can talloc_free "conn" if the client requests
    close_on_completion. "state" is a talloc_child of conn, so it will be gone when
    we later free state->data et al.

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/ipc.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/ipc.c b/source3/smbd/ipc.c
index f20c851..5fd756e 100644
--- a/source3/smbd/ipc.c
+++ b/source3/smbd/ipc.c
@@ -750,6 +750,8 @@ void reply_trans(struct smb_request *req)
 		return;
 	}
 
+	talloc_steal(talloc_tos(), state);
+
 	handle_trans(conn, req, state);
 
 	SAFE_FREE(state->data);
@@ -848,6 +850,8 @@ void reply_transs(struct smb_request *req)
 		return;
 	}
 
+	talloc_steal(talloc_tos(), state);
+
 	handle_trans(conn, req, state);
 
 	DLIST_REMOVE(conn->pending_trans, state);


-- 
Samba Shared Repository