[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4180-g14fec47

[Jeremy Allison]

The branch, v3-3-test has been updated
       via  14fec47f7171591e5799b81c90c3f5a856002ed0 (commit)
      from  af1878009e0bb7ef43bf445f5c167f3bbcc43fd2 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 14fec47f7171591e5799b81c90c3f5a856002ed0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 26 15:13:41 2008 -0700

    Fix bug #5797 - Moving readonly files fails. Reported by infomail at lordb.de.
    We don't need to deny a DELETE open on a readonly file (I'm also adding a s4
    torture test for this), the set_file_disposition call will return
    NT_STATUS_CANNOT_DELETE if the delete-on-close bit is set
    on a readonly file (and we already do this).
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/open.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/open.c b/source/smbd/open.c
index 7119147..ad024a5 100644
--- a/source/smbd/open.c
+++ b/source/smbd/open.c
@@ -2608,9 +2608,7 @@ NTSTATUS create_file_unixpath(connection_struct *conn,
 	    && (create_disposition != FILE_CREATE)
 	    && (share_access & FILE_SHARE_DELETE)
 	    && (access_mask & DELETE_ACCESS)
-	    && (((dos_mode(conn, fname, &sbuf) & FILE_ATTRIBUTE_READONLY)
-		 && !lp_delete_readonly(SNUM(conn)))
-		|| !can_delete_file_in_directory(conn, fname))) {
+	    && (!can_delete_file_in_directory(conn, fname))) {
 		status = NT_STATUS_ACCESS_DENIED;
 		goto fail;
 	}


-- 
Samba Shared Repository