[SCM] CTDB repository - branch master updated - ctdb-1.0.57-24-g5e641ef

Ronnie Sahlberg sahlberg at samba.org
Mon Sep 15 23:05:21 GMT 2008


The branch, master has been updated
       via  5e641ef9d6cca286061138a9680dcf2495736e8b (commit)
      from  95bf36559d62f29e6f538f3a173b504ef3258341 (commit)

http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 5e641ef9d6cca286061138a9680dcf2495736e8b
Author: Ronnie Sahlberg <ronniesahlberg at gmail.com>
Date:   Tue Sep 16 09:00:48 2008 +1000

    fix a slow memory leak in the recovery daemon in the error paths for the
    memdump function

-----------------------------------------------------------------------

Summary of changes:
 server/ctdb_recoverd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/server/ctdb_recoverd.c b/server/ctdb_recoverd.c
index 779d26f..b17f989 100644
--- a/server/ctdb_recoverd.c
+++ b/server/ctdb_recoverd.c
@@ -1753,6 +1753,7 @@ static void mem_dump_handler(struct ctdb_context *ctdb, uint64_t srvid,
 
 	if (data.dsize != sizeof(struct rd_memdump_reply)) {
 		DEBUG(DEBUG_ERR, (__location__ " Wrong size of return address.\n"));
+		talloc_free(tmp_ctx);
 		return;
 	}
 	rd = (struct rd_memdump_reply *)data.dptr;
@@ -1775,6 +1776,7 @@ DEBUG(DEBUG_ERR, ("recovery master memory dump\n"));
 	ret = ctdb_send_message(ctdb, rd->pnn, rd->srvid, *dump);
 	if (ret != 0) {
 		DEBUG(DEBUG_ERR,("Failed to send rd memdump reply message\n"));
+		talloc_free(tmp_ctx);
 		return;
 	}
 


-- 
CTDB repository


More information about the samba-cvs mailing list