[SCM] CTDB repository - branch master updated - ctdb-1.0.57-22-g0aca4da

Ronnie Sahlberg sahlberg at samba.org
Mon Sep 15 20:53:03 GMT 2008


The branch, master has been updated
       via  0aca4daf908b76d6013ff3dfad41beb9114fc1a3 (commit)
      from  a120c734c5425ebb2e09c2009374aa0bc5a432e8 (commit)

http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 0aca4daf908b76d6013ff3dfad41beb9114fc1a3
Author: Ronnie Sahlberg <ronniesahlberg at gmail.com>
Date:   Tue Sep 16 06:50:28 2008 +1000

    From Volker L
    Fix a slow memory leak in the recovery daemon if there is a recoery
    triggered during the public ip reassignment process

-----------------------------------------------------------------------

Summary of changes:
 server/ctdb_recoverd.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/server/ctdb_recoverd.c b/server/ctdb_recoverd.c
index 4753942..af1c358 100644
--- a/server/ctdb_recoverd.c
+++ b/server/ctdb_recoverd.c
@@ -2181,6 +2181,7 @@ static int verify_ip_allocation(struct ctdb_context *ctdb, uint32_t pnn)
 	if (timeval_compare(&uptime1->last_recovery_started,
 			    &uptime2->last_recovery_started) != 0) {
 		DEBUG(DEBUG_NOTICE, (__location__ " last recovery time changed while we read the public ip list. skipping public ip address check\n"));
+		talloc_free(mem_ctx);
 		return 0;
 	}
 
@@ -2188,6 +2189,7 @@ static int verify_ip_allocation(struct ctdb_context *ctdb, uint32_t pnn)
 	if (timeval_compare(&uptime1->last_recovery_finished,
 			    &uptime2->last_recovery_finished) != 0) {
 		DEBUG(DEBUG_NOTICE, (__location__ " last recovery time changed while we read the public ip list. skipping public ip address check\n"));
+		talloc_free(mem_ctx);
 		return 0;
 	}
 
@@ -2195,6 +2197,7 @@ static int verify_ip_allocation(struct ctdb_context *ctdb, uint32_t pnn)
 	if (timeval_compare(&uptime1->last_recovery_finished,
 			    &uptime1->last_recovery_started) != 1) {
 		DEBUG(DEBUG_NOTICE, (__location__ " in the middle of recovery. skipping public ip address check\n"));
+		talloc_free(mem_ctx);
 
 		return 0;
 	}


-- 
CTDB repository


More information about the samba-cvs mailing list