[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha5-483-g937b466

[Andrew Bartlett]

The branch, v4-0-test has been updated
       via  937b466266256d26d02cf8d48e72a26272fe8627 (commit)
      from  6f89e728272ca14f0ed9557485e21647c0731ef2 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test


- Log -----------------------------------------------------------------
commit 937b466266256d26d02cf8d48e72a26272fe8627
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Sep 9 16:18:27 2008 +1000

    Fix bug #5713 by correcting the generated schema.
    
    This bug is entitled 'Schema patch breaks interoperability with
    Microsoft MMC consoles.', and it does so very spectacularly.
    
    The issue is that we would include an entry:
    objectClasses: ( 2.5.6.0 NAME 'top' SUP top ABSTRACT..
    
    The MMC Active Directory Users and Computers snap in presumably
    objected to the 'loop' this would present. The fixed entry is:
    
    objectClasses: ( 2.5.6.0 NAME 'top' ABSTRACT
    
    Thanks to Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de> for his
    persistance in getting me to look at this.
    
    Andrew Bartlett

-----------------------------------------------------------------------

Summary of changes:
 source/dsdb/schema/schema_description.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/dsdb/schema/schema_description.c b/source/dsdb/schema/schema_description.c
index 9d93af9..d780fcf 100644
--- a/source/dsdb/schema/schema_description.c
+++ b/source/dsdb/schema/schema_description.c
@@ -182,7 +182,7 @@ char *schema_class_description(TALLOC_CTX *mem_ctx,
 		IF_NULL_FAIL_RET(schema_entry);
 	}
 
-	if (subClassOf) {
+	if (subClassOf && strcasecmp(subClassOf, name) == 0) {
 		schema_entry = talloc_asprintf_append(schema_entry, 
 						      "SUP %s%s", subClassOf, seperator);
 		IF_NULL_FAIL_RET(schema_entry);


-- 
Samba Shared Repository