[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3931-g5f08200

Volker Lendecke vlendec at samba.org
Mon Sep 1 11:50:08 GMT 2008


The branch, v3-3-test has been updated
       via  5f082003bdd0bb06b391cb0dd0cf6287ba3b99c8 (commit)
      from  9d6bfc6c216304f31456cf181dc5e23824e2e54f (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 5f082003bdd0bb06b391cb0dd0cf6287ba3b99c8
Author: Volker Lendecke <vl at sernet.de>
Date:   Mon Sep 1 13:46:27 2008 +0200

    Fix Coverity ID 587
    
    The following test program prints "8" on 64-bit :-)
    
    static void print_size(const char lenbuf[4])
    {
            printf("sizeof(lenbuf) = %d\n", (int)sizeof(lenbuf));
    }
    int main(void)
    {
            const char lenbuf[4];
            print_size(lenbuf);
            return 0;
    }
    
    Jeremy, please check :-)
    
    Volker
    (cherry picked from commit 9daea0ccfdda58450be3c9a9a94c016f5900c319)

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/process.c b/source/smbd/process.c
index 332a2e4..b2d19e1 100644
--- a/source/smbd/process.c
+++ b/source/smbd/process.c
@@ -164,7 +164,7 @@ static NTSTATUS receive_smb_raw_talloc_partial_read(TALLOC_CTX *mem_ctx,
 	ssize_t toread;
 	NTSTATUS status;
 
-	memcpy(writeX_header, lenbuf, sizeof(lenbuf));
+	memcpy(writeX_header, lenbuf, 4);
 
 	status = read_socket_with_timeout(
 		fd, writeX_header + 4,


-- 
Samba Shared Repository


More information about the samba-cvs mailing list