[SCM] Samba Shared Repository - branch master updated - 753af36a3e194f645ec0b68a033199035e71c909

[Simo Sorce]

The branch, master has been updated
       via  753af36a3e194f645ec0b68a033199035e71c909 (commit)
      from  7c5f369fafee42b555c3e2b3e3482689b508fe4a (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 753af36a3e194f645ec0b68a033199035e71c909
Author: Simo Sorce <idra at samba.org>
Date:   Wed Oct 29 08:34:05 2008 -0400

    Length comparison of the linearized version is not correct.
    The linearized version is not casefolded so length might not match
    and yet the strings be equivalent. This can happen if one component
    is case-insensitive and a letter that have an uppercase version of
    a multibyte character that differ in legth from the corresponding
    lowercase one.

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/ldb/common/ldb_dn.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/ldb/common/ldb_dn.c b/source4/lib/ldb/common/ldb_dn.c
index e36aea4..5e6fb96 100644
--- a/source4/lib/ldb/common/ldb_dn.c
+++ b/source4/lib/ldb/common/ldb_dn.c
@@ -749,9 +749,6 @@ int ldb_dn_compare_base(struct ldb_dn *base, struct ldb_dn *dn)
 		if (base->linearized && dn->linearized) {
 			/* try with a normal compare first, if we are lucky
 			 * we will avoid exploding and casfolding */
-			int dif;
-			dif = strlen(dn->linearized) - strlen(base->linearized);
-			if (dif < 0) return dif;
 			if (strcmp(base->linearized, &dn->linearized[dif]) == 0) return 0;
 		}
 


-- 
Samba Shared Repository