[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4297-g89e22a2

[Derrell Lipman]

The branch, v3-3-test has been updated
       via  89e22a2c969ab7a38016d4a145feb061fa6ae108 (commit)
      from  93eca985258a1ee56627704d448a4c0c40d2ec50 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 89e22a2c969ab7a38016d4a145feb061fa6ae108
Author: Derrell Lipman <derrell.lipman at unwireduniverse.com>
Date:   Fri Oct 24 11:19:12 2008 -0400

    Error return is False, not -1
    
    - There were a few places in SMBC_getatr() that returned -1 instead of a
      boolean.  -1 was intended to mean error, but that's what False is for, and
      the usages of this function assume that it returns a boolean with False as
      the error condition.
    
    - per Jelmer's request, use false vs. False in new code, even if not making
      changes globally.
    
    Derrell

-----------------------------------------------------------------------

Summary of changes:
 source/libsmb/libsmb_file.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libsmb/libsmb_file.c b/source/libsmb/libsmb_file.c
index 7b28709..e162aaa 100644
--- a/source/libsmb/libsmb_file.c
+++ b/source/libsmb/libsmb_file.c
@@ -518,7 +518,7 @@ SMBC_getatr(SMBCCTX * context,
                 
 		errno = EINVAL;
 		TALLOC_FREE(frame);
- 		return -1;
+ 		return false;
  	}
         
 	/* path fixup for . and .. */
@@ -527,14 +527,14 @@ SMBC_getatr(SMBCCTX * context,
 		if (!fixedpath) {
 			errno = ENOMEM;
 			TALLOC_FREE(frame);
-			return -1;
+			return false;
 		}
 	} else {
 		fixedpath = talloc_strdup(frame, path);
 		if (!fixedpath) {
 			errno = ENOMEM;
 			TALLOC_FREE(frame);
-			return -1;
+			return false;
 		}
 		trim_string(fixedpath, NULL, "\\..");
 		trim_string(fixedpath, NULL, "\\.");


-- 
Samba Shared Repository