[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4267-g218879c

Jeremy Allison jra at samba.org
Fri Oct 17 04:04:04 GMT 2008


The branch, v3-3-test has been updated
       via  218879cb9069046df2b7e49627aa48cb487098c8 (commit)
      from  ca430d4730c1454cf003dab376bde8baf904d77d (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 218879cb9069046df2b7e49627aa48cb487098c8
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 16 21:03:19 2008 -0700

    Cope with bad trans2mkdir requests from System i QNTC IBM SMB client.
    If total_data == 4 Windows doesn't care what values
    are placed in that field, it just ignores them.
    The System i QNTC IBM SMB client puts bad values here,
    so ignore them.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/trans2.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/trans2.c b/source/smbd/trans2.c
index 1e2095a..146746b 100644
--- a/source/smbd/trans2.c
+++ b/source/smbd/trans2.c
@@ -7065,10 +7065,11 @@ static void call_trans2mkdir(connection_struct *conn, struct smb_request *req,
 			reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
 			return;
 		}
-	} else if (IVAL(pdata,0) != 4) {
-		reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
-		return;
 	}
+	/* If total_data == 4 Windows doesn't care what values
+	 * are placed in that field, it just ignores them.
+	 * The System i QNTC IBM SMB client puts bad values here,
+	 * so ignore them. */
 
 	status = create_directory(conn, req, directory);
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list