[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3071-g5236507

[Jeremy Allison]

The branch, v3-2-test has been updated
       via  52365077e74e80959a42aa82cf9a6c959e2fcda5 (commit)
       via  65169e4b5f182f1614e102bb0e09326a26bd5b5d (commit)
       via  de581efedbc53a783a680ff366d37aeccd14ee23 (commit)
      from  4dc2eb7f42bad6812d21bf4577e2901b04a5ca83 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 52365077e74e80959a42aa82cf9a6c959e2fcda5
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Oct 4 19:39:39 2008 -0700

    Fix an unlikely memleak found by the IBM checker

commit 65169e4b5f182f1614e102bb0e09326a26bd5b5d
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Oct 4 19:38:42 2008 -0700

    Fix an uninitialized variable found by the IBM Checker

commit de581efedbc53a783a680ff366d37aeccd14ee23
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Oct 4 19:38:04 2008 -0700

    Fix a potential NULL deref in line 258 found by the IBM checker

-----------------------------------------------------------------------

Summary of changes:
 source/libaddns/dnsmarshall.c |    1 +
 source/libads/ldap.c          |    1 +
 source/libads/util.c          |    2 ++
 3 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libaddns/dnsmarshall.c b/source/libaddns/dnsmarshall.c
index 8c3389e..5530290 100644
--- a/source/libaddns/dnsmarshall.c
+++ b/source/libaddns/dnsmarshall.c
@@ -252,6 +252,7 @@ void dns_unmarshall_domain_name(TALLOC_CTX *mem_ctx,
 
 	if (!(name = talloc(mem_ctx, struct dns_domain_name))) {
 		buf->error = ERROR_DNS_NO_MEMORY;
+		return;
 	}
 
 	dns_unmarshall_label(name, 0, buf, &name->pLabelList);
diff --git a/source/libads/ldap.c b/source/libads/ldap.c
index 063645f..842e4fd 100644
--- a/source/libads/ldap.c
+++ b/source/libads/ldap.c
@@ -2639,6 +2639,7 @@ ADS_STATUS ads_domain_func_level(ADS_STRUCT *ads, uint32 *val)
 		if ( (ads_s = ads_init( ads->server.realm, ads->server.workgroup, 
 			ads->server.ldap_server )) == NULL )
 		{
+			status = ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
 			goto done;
 		}
 		ads_s->auth.flags = ADS_AUTH_ANON_BIND;
diff --git a/source/libads/util.c b/source/libads/util.c
index 72f5dee..d23c36f 100644
--- a/source/libads/util.c
+++ b/source/libads/util.c
@@ -86,6 +86,8 @@ ADS_STATUS ads_guess_service_principal(ADS_STRUCT *ads,
 		server_realm = SMB_STRDUP(ads->config.realm);
 
 		if (!server || !server_realm) {
+			SAFE_FREE(server);
+			SAFE_FREE(server_realm);
 			return ADS_ERROR(LDAP_NO_MEMORY);
 		}
 


-- 
Samba Shared Repository