[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-32-70-g114b94f

Michael Adam obnox at samba.org
Mon Nov 24 14:31:05 GMT 2008


The branch, v3-0-test has been updated
       via  114b94f86e15d482f3b39912f28eb72b66b36bc8 (commit)
      from  a2329ec0eea66108f44dae3853e578dbbf835f96 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test


- Log -----------------------------------------------------------------
commit 114b94f86e15d482f3b39912f28eb72b66b36bc8
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Nov 24 15:26:21 2008 +0100

    libads/ldap.c: return an error instead of crashing when no realm is given
    
    The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't ex
    and "disable netbios = yes".
    
    metze
    
    Signed-off-by: Michael Adam <obnox at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source/libads/ldap.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libads/ldap.c b/source/libads/ldap.c
index 4e18ff7..36e8693 100644
--- a/source/libads/ldap.c
+++ b/source/libads/ldap.c
@@ -284,11 +284,11 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
 			if ( use_own_domain )
 				c_realm = lp_workgroup();
 		}
-		
-		if ( !c_realm || !*c_realm ) {
-			DEBUG(0,("ads_find_dc: no realm or workgroup!  Don't know what to do\n"));
-			return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */
-		}
+	}
+
+	if ( !c_realm || !*c_realm ) {
+		DEBUG(0,("ads_find_dc: no realm or workgroup!  Don't know what to do\n"));
+		return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */
 	}
 
 	if ( use_own_domain ) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list