[SCM] Samba Shared Repository - branch master updated - 26461a72da5a646fcc6023bb4f82c66e17a8529b

[Michael Adam]

The branch, master has been updated
       via  26461a72da5a646fcc6023bb4f82c66e17a8529b (commit)
      from  f340ed1348ca5f514dcd85a273559ecb9ff1615f (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 26461a72da5a646fcc6023bb4f82c66e17a8529b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Nov 24 15:04:12 2008 +0100

    s3:libads/ldap.c: return an error instead of crashing when no realm is given
    
    The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't ex
    and "disable netbios = yes".
    
    metze
    
    Signed-off-by: Michael Adam <obnox at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source3/libads/ldap.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index f55cfa7..932e42e 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -301,11 +301,11 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads)
 			if ( use_own_domain )
 				c_realm = lp_workgroup();
 		}
+	}
 
-		if ( !c_realm || !*c_realm ) {
-			DEBUG(0,("ads_find_dc: no realm or workgroup!  Don't know what to do\n"));
-			return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */
-		}
+	if ( !c_realm || !*c_realm ) {
+		DEBUG(0,("ads_find_dc: no realm or workgroup!  Don't know what to do\n"));
+		return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */
 	}
 
 	realm = c_realm;


-- 
Samba Shared Repository