[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4452-g113c5d2

Günther Deschner gd at samba.org
Thu Nov 20 16:13:31 GMT 2008


The branch, v3-3-test has been updated
       via  113c5d28edabdd17a2507e68aad612aa21c758f3 (commit)
      from  e543bcc4e9da7c6e4cbfab7082a09eaefb48ed6b (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 113c5d28edabdd17a2507e68aad612aa21c758f3
Author: Michael Adam <obnox at samba.org>
Date:   Thu Nov 20 16:31:44 2008 +0100

    eventlog: don't crash in sync_eventlog_params().
    
    When freeing the talloc ctx at the end of the routine,
    it must be a talloc ctx created inside. talloc_tos() needs
    to be valid after the function finishes, since callers
    (may) have data attached to it.
    
    Michael
    
    Signed-off-by: Günther Deschner <gd at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source/rpc_server/srv_eventlog_nt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/rpc_server/srv_eventlog_nt.c b/source/rpc_server/srv_eventlog_nt.c
index 9c3ffda..70c3224 100644
--- a/source/rpc_server/srv_eventlog_nt.c
+++ b/source/rpc_server/srv_eventlog_nt.c
@@ -426,7 +426,7 @@ static bool sync_eventlog_params( EVENTLOG_INFO *info )
 	struct registry_value *value;
 	WERROR wresult;
 	char *elogname = info->logname;
-	TALLOC_CTX *ctx = talloc_tos();
+	TALLOC_CTX *ctx = talloc_stackframe();
 	bool ret = false;
 
 	DEBUG( 4, ( "sync_eventlog_params with %s\n", elogname ) );


-- 
Samba Shared Repository


More information about the samba-cvs mailing list