[SCM] Samba Shared Repository - branch master updated - 172628dca2b8553b8b7273a645393d5c96daa67e

Günther Deschner gd at samba.org
Thu Nov 20 16:10:21 GMT 2008


The branch, master has been updated
       via  172628dca2b8553b8b7273a645393d5c96daa67e (commit)
      from  da683d6a73a37d18aa8fca52ef2b4837c7ff1345 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 172628dca2b8553b8b7273a645393d5c96daa67e
Author: Michael Adam <obnox at samba.org>
Date:   Thu Nov 20 16:31:44 2008 +0100

    eventlog: don't crash in sync_eventlog_params().
    
    When freeing the talloc ctx at the end of the routine,
    it must be a talloc ctx created inside. talloc_tos() needs
    to be valid after the function finishes, since callers
    (may) have data attached to it.
    
    Michael
    
    Signed-off-by: Günther Deschner <gd at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/srv_eventlog_nt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/srv_eventlog_nt.c b/source3/rpc_server/srv_eventlog_nt.c
index de2bafc..71257df 100644
--- a/source3/rpc_server/srv_eventlog_nt.c
+++ b/source3/rpc_server/srv_eventlog_nt.c
@@ -426,7 +426,7 @@ static bool sync_eventlog_params( EVENTLOG_INFO *info )
 	struct registry_value *value;
 	WERROR wresult;
 	char *elogname = info->logname;
-	TALLOC_CTX *ctx = talloc_tos();
+	TALLOC_CTX *ctx = talloc_stackframe();
 	bool ret = false;
 
 	DEBUG( 4, ( "sync_eventlog_params with %s\n", elogname ) );


-- 
Samba Shared Repository


More information about the samba-cvs mailing list