[SCM] Samba Shared Repository - branch master updated - 1b41f670fc40ac583f546440c2a683e94eb05caf

Volker Lendecke vlendec at samba.org
Fri Nov 14 11:57:40 GMT 2008


The branch, master has been updated
       via  1b41f670fc40ac583f546440c2a683e94eb05caf (commit)
      from  4c7033df5da52bded995f3e4cccd0b78bf55a74f (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 1b41f670fc40ac583f546440c2a683e94eb05caf
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 14 12:49:18 2008 +0100

    sys_pwnam doesn't return talloced memory, so don't mix up the returned struct.
    (cherry picked from commit eb99923991960e53bd150ac8f1d818cb746101b4)

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/util_pw.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/util_pw.c b/source3/lib/util_pw.c
index e0dbc97..e138273 100644
--- a/source3/lib/util_pw.c
+++ b/source3/lib/util_pw.c
@@ -59,10 +59,7 @@ struct passwd *getpwnam_alloc(TALLOC_CTX *mem_ctx, const char *name)
 
 	cached = tcopy_passwd(talloc_autofree_context(), temp);
 	if (cached == NULL) {
-		/*
-		 * Just don't add this into the cache, ignore the failure
-		 */
-		return temp;
+		return NULL;
 	}
 
 	memcache_add_talloc(NULL, GETPWNAM_CACHE, data_blob_string_const_null(name),


-- 
Samba Shared Repository


More information about the samba-cvs mailing list