[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3143-geb99923

Volker Lendecke vlendec at samba.org
Fri Nov 14 11:54:06 GMT 2008


The branch, v3-2-test has been updated
       via  eb99923991960e53bd150ac8f1d818cb746101b4 (commit)
      from  b04a4001813cf0427539a52b0abd2e9a1fa1e5eb (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit eb99923991960e53bd150ac8f1d818cb746101b4
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 14 12:49:18 2008 +0100

    sys_pwnam doesn't return talloced memory, so don't mix up the returned struct.

-----------------------------------------------------------------------

Summary of changes:
 source/lib/util_pw.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/util_pw.c b/source/lib/util_pw.c
index 4283785..342e509 100644
--- a/source/lib/util_pw.c
+++ b/source/lib/util_pw.c
@@ -59,10 +59,7 @@ struct passwd *getpwnam_alloc(TALLOC_CTX *mem_ctx, const char *name)
 
 	cached = tcopy_passwd(NULL, temp);
 	if (cached == NULL) {
-		/*
-		 * Just don't add this into the cache, ignore the failure
-		 */
-		return temp;
+		return NULL;
 	}
 
 	memcache_add_talloc(NULL, GETPWNAM_CACHE, data_blob_string_const(name),


-- 
Samba Shared Repository


More information about the samba-cvs mailing list