[ks@sernet.de: Re: [SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-2485-g1c4adc8]

Karolin Seeger ks at sernet.de
Mon May 19 13:25:12 GMT 2008


Hi, Jeremy!

That one is now in v3-2-stable together with two other patches needed to
fix the build. Thanks Günther! :-)

Cheers,
Karolin

----- Forwarded message from Karolin Seeger <ks at sernet.de> -----

Return-path: samba-technical-bounces+ks=sernet.de at lists.samba.org
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on gabi.sernet.de
X-Spam-Level: 
X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,
	RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3
Envelope-to: ks at sernet.de
Delivery-date: Mon, 19 May 2008 09:27:52 +0200
Received: by intern.SerNet.DE
	id 1Jxzmi-00070v-4Q; Mon, 19 May 2008 09:27:52 +0200
Received: by intern.SerNet.DE
	id 1Jxzmh-00070s-NQ; Mon, 19 May 2008 09:27:51 +0200
Received: from mail.samba.org ([66.70.73.150] helo=lists.samba.org)
	by mail.SerNet.de with esmtp (Exim 4.63 #1)
	for ks at sernet.de
	id 1Jxzmh-0005Q1-EJ; Mon, 19 May 2008 09:27:51 +0200
Received: from dp.samba.org (localhost [127.0.0.1])
	by lists.samba.org (Postfix) with ESMTP id 08301163989
	for <ks at sernet.de>; Mon, 19 May 2008 07:27:46 +0000 (GMT)
X-Original-To: samba-technical at lists.samba.org
Delivered-To: samba-technical at lists.samba.org
Received: from mail.SerNet.de (mail.SerNet.DE [193.175.80.2])
	by lists.samba.org (Postfix) with ESMTP id 81343162C25;
	Mon, 19 May 2008 07:27:17 +0000 (GMT)
Received: from intern.SerNet.DE by mail.SerNet.DE with esmtp (Exim 4.63 #1)
	id 1Jxzm9-0005OH-0W; Mon, 19 May 2008 09:27:17 +0200
Received: by intern.SerNet.DE
	id 1Jxzm8-0006xe-R4; Mon, 19 May 2008 09:27:16 +0200
Received: by intern.SerNet.DE
	id 1Jxzm8-0006xb-AA; Mon, 19 May 2008 09:27:16 +0200
Received: by bando.sernet.private (Postfix, from userid 8362)
	id 8F4C53A072C; Mon, 19 May 2008 09:27:48 +0200 (CEST)
Date: Mon, 19 May 2008 09:27:49 +0200
From: Karolin Seeger <ks at sernet.de>
To: Jeremy Allison <jra at samba.org>
References: <20080516122352.4E16C1CC013 at us2.samba.org>
	<20080516170201.GA25545 at samba1>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="p4qYPpj5QlsIQJ0K"
Content-Disposition: inline
In-Reply-To: <20080516170201.GA25545 at samba1>
Priority: normal
User-Agent: Mutt/1.5.16 (2007-06-09)
Message-Id: <E1Jxzm8-0006xe-R4 at intern.SerNet.DE>
Organization: SerNet GmbH, Goettingen, Germany
Cc: gd at samba.org, samba-technical at lists.samba.org
Subject: Re: [SCM] Samba Shared Repository - branch v3-3-test updated -
	release-3-2-0pre2-2485-g1c4adc8
X-BeenThere: samba-technical at lists.samba.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions on Samba internals. For general questions please
	subscribe to the list samba at samba.org"
	<samba-technical.lists.samba.org>
List-Unsubscribe: <https://lists.samba.org/mailman/listinfo/samba-technical>, 
	<mailto:samba-technical-request at lists.samba.org?subject=unsubscribe>
List-Archive: <http://lists.samba.org/archive/samba-technical>
List-Post: <mailto:samba-technical at lists.samba.org>
List-Help: <mailto:samba-technical-request at lists.samba.org?subject=help>
List-Subscribe: <https://lists.samba.org/mailman/listinfo/samba-technical>,
	<mailto:samba-technical-request at lists.samba.org?subject=subscribe>
Errors-To: samba-technical-bounces+ks=sernet.de at lists.samba.org

On Fri, May 16, 2008 at 10:02:01AM -0700, Jeremy Allison wrote:
> On Fri, May 16, 2008 at 07:23:51AM -0500, Günther Deschner wrote:
> > The branch, v3-3-test has been updated
> >        via  1c4adc8dda68eae9839bdff843aadf8c98dd9e87 (commit)
> >       from  452a9ea4af19d3aebc35929edaf4e5adf8c1fd11 (commit)
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 1c4adc8dda68eae9839bdff843aadf8c98dd9e87
> > Author: Günther Deschner <gd at samba.org>
> > Date:   Fri May 16 13:24:15 2008 +0200
> > 
> >     Fix Bug #5461 and implement a very basic _samr_GetDisplayEnumerationIndex().
> >     
> >     Citrix PM cannot use a Samba DC when having more then 900 groups as citrix
> >     insists on calling _samr_GetDisplayEnumerationIndex() after receiving the first
> >     900 groups via _samr_QueryDisplayInfo() to get the continuation index.
> >     
> >     Guenther
> 
> Karolin, Guenther - I think this needs to be in 3.2-stable also.
> Now we have it in 3.0.x we must have the same fix in 3.2 else 3.2
> will be a regression against 3.0.x in this area.
 
I just tried to compile after applying the patch and it failed with:

-----8<------------------snip--------------8<--------------
Compiling rpc_server/srv_samr_nt.c
rpc_server/srv_samr_nt.c: In function ‘_samr_GetDisplayEnumerationIndex’:
rpc_server/srv_samr_nt.c:5756: error: invalid type argument of ‘->’
rpc_server/srv_samr_nt.c:5760: error: invalid type argument of ‘->’
rpc_server/srv_samr_nt.c:5761: error: invalid type argument of ‘->’
The following command failed:
gcc -I. -I/data/git/samba/v3-2-stable/source  -O -g -D_SAMBA_BUILD_=3 -g
-Wall -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
-DDEBUG_PASSWORD -DDEVELOPER -Wdeclaration-after-statement
-Werror-implicit-function-declaration
-I/data/git/samba/v3-2-stable/source/popt
-I/data/git/samba/v3-2-stable/source/iniparser/src -Iinclude -I./include
-I. -I. -I./lib/replace -I./lib/talloc -I./lib/tdb/include -I./libaddns
-I./librpc -DHAVE_CONFIG_H  -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
-D_GNU_SOURCE -Iinclude -I./include -I. -I. -I./lib/replace -I./lib/talloc
-I./lib/tdb/include -I./libaddns -I./librpc -I./popt -DLDAP_DEPRECATED
-I/include -I/data/git/samba/v3-2-stable/source/lib -D_SAMBA_BUILD_=3
-fPIC -c rpc_server/srv_samr_nt.c -o rpc_server/srv_samr_nt.o
make: *** [rpc_server/srv_samr_nt.o] Fehler 1
----->8------------------snap-------------->8--------------

Karolin

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE




----- End forwarded message -----

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-cvs/attachments/20080519/34a4e4b4/attachment.bin


More information about the samba-cvs mailing list