[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-28a-1166-g9727d87

Jeremy Allison jra at samba.org
Thu May 15 02:06:27 GMT 2008


The branch, v3-0-test has been updated
       via  9727d87e7c8748fecf7df5664320507711a7d081 (commit)
      from  614063e0b892adb31c4b5c016669bc8e68da7632 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test


- Log -----------------------------------------------------------------
commit 9727d87e7c8748fecf7df5664320507711a7d081
Author: Jeremy Allison <jra at samba.org>
Date:   Wed May 14 19:05:26 2008 -0700

    lm_session_key is only 8 bytes. Don't confuse developers (ie. me :-)
    by passing around 16 bytes, 8 of which end up unused.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/rpc_parse/parse_net.c      |    2 +-
 source/rpc_server/srv_netlog_nt.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/rpc_parse/parse_net.c b/source/rpc_parse/parse_net.c
index 5837ee6..693de2d 100644
--- a/source/rpc_parse/parse_net.c
+++ b/source/rpc_parse/parse_net.c
@@ -1430,7 +1430,7 @@ void init_net_user_info3(TALLOC_CTX *ctx, NET_USER_INFO_3 *usr,
  		 	 uint32 num_groups, const DOM_GID *gids,
 			 uint32 user_flgs, uint32 acct_flags,
 			 uchar user_session_key[16],
-			 uchar lm_session_key[16],
+			 uchar lm_session_key[8],
  			 const char *logon_srv, const char *logon_dom,
 			 const DOM_SID *dom_sid)
 {
diff --git a/source/rpc_server/srv_netlog_nt.c b/source/rpc_server/srv_netlog_nt.c
index b8c7769..605fae7 100644
--- a/source/rpc_server/srv_netlog_nt.c
+++ b/source/rpc_server/srv_netlog_nt.c
@@ -973,7 +973,7 @@ static NTSTATUS _net_sam_logon_internal(pipes_struct *p,
 		fstring user_sid_string;
 		fstring group_sid_string;
 		unsigned char user_session_key[16];
-		unsigned char lm_session_key[16];
+		unsigned char lm_session_key[8];
 		unsigned char pipe_session_key[16];
 
 		sampw = server_info->sam_account;
@@ -1054,7 +1054,7 @@ static NTSTATUS _net_sam_logon_internal(pipes_struct *p,
 				}
 				memcpy(pipe_session_key, p->auth.a_u.schannel_auth->sess_key, 16);
 			}
-			SamOEMhash(lm_session_key, pipe_session_key, 16);
+			SamOEMhash(lm_session_key, pipe_session_key, 8);
 			memset(pipe_session_key, '\0', 16);
 		}
 		


-- 
Samba Shared Repository


More information about the samba-cvs mailing list