[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-537-g73ead75

Günther Deschner gd at samba.org
Fri Mar 28 23:51:25 GMT 2008


The branch, v3-2-test has been updated
       via  73ead752c5ec7104ea0eed7d963dc36467c81981 (commit)
       via  6a576cfe9b87e69af6acbe9abc04124b8b743fd3 (commit)
      from  58018ad7f65409d971e5db7165f1b32b572cc275 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 73ead752c5ec7104ea0eed7d963dc36467c81981
Author: Günther Deschner <gd at samba.org>
Date:   Sat Mar 29 00:49:09 2008 +0100

    Zero initial return_authenticator in net rpc samdump.
    
    Guenther

commit 6a576cfe9b87e69af6acbe9abc04124b8b743fd3
Author: Günther Deschner <gd at samba.org>
Date:   Sat Mar 29 00:47:42 2008 +0100

    Don't let winbind getgroups crash when we have no gids in the token.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source/utils/net_rpc_samsync.c   |    2 ++
 source/winbindd/winbindd_group.c |    8 +++++---
 2 files changed, 7 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/utils/net_rpc_samsync.c b/source/utils/net_rpc_samsync.c
index 80bc6ee..87d35b3 100644
--- a/source/utils/net_rpc_samsync.c
+++ b/source/utils/net_rpc_samsync.c
@@ -337,6 +337,8 @@ static void dump_database(struct rpc_pipe_client *pipe_hnd,
 	uint16_t restart_state = 0;
 	uint32_t sync_context = 0;
 
+	ZERO_STRUCT(return_authenticator);
+
 	if (!(mem_ctx = talloc_init("dump_database"))) {
 		return;
 	}
diff --git a/source/winbindd/winbindd_group.c b/source/winbindd/winbindd_group.c
index 6a704cf..5dbd8c5 100644
--- a/source/winbindd/winbindd_group.c
+++ b/source/winbindd/winbindd_group.c
@@ -1595,9 +1595,11 @@ static void getgroups_sid2gid_recv(void *private_data, bool success, gid_t gid)
 	}
 
 	s->state->response.data.num_entries = s->num_token_gids;
-	/* s->token_gids are talloced */
-	s->state->response.extra_data.data = smb_xmemdup(s->token_gids, s->num_token_gids * sizeof(gid_t));
-	s->state->response.length += s->num_token_gids * sizeof(gid_t);
+	if (s->num_token_gids) {
+		/* s->token_gids are talloced */
+		s->state->response.extra_data.data = smb_xmemdup(s->token_gids, s->num_token_gids * sizeof(gid_t));
+		s->state->response.length += s->num_token_gids * sizeof(gid_t);
+	}
 	request_ok(s->state);
 }
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list