[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-411-g07a9f7d

[Volker Lendecke]

The branch, v3-2-test has been updated
       via  07a9f7daa83c94afefe0d81db4812135121862c2 (commit)
       via  4e6f8a19a6861c332ee6e9b49551e12440eefdc2 (commit)
       via  5c43c38271bae7d96d0cfbdaba7bff838a684b40 (commit)
       via  a0859529c853ffb756b1deee946923b6fff6136e (commit)
       via  22cee9c1afbc33b4920b72bc81569d79642172af (commit)
      from  d3b6df67fea0da5ffa962837400ebe07b34a5384 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 07a9f7daa83c94afefe0d81db4812135121862c2
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Mar 23 19:43:36 2008 +0100

    Fix Coverity ID 514
    
    Not exactly an uninitialized variable, but having Coverity figure out that
    we're only UNMARSHALLING here is probably asking for a bit too much.

commit 4e6f8a19a6861c332ee6e9b49551e12440eefdc2
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Mar 23 19:38:50 2008 +0100

    Fix Coverity ID 504

commit 5c43c38271bae7d96d0cfbdaba7bff838a684b40
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Mar 23 19:38:02 2008 +0100

    Fix Coverity ID 503

commit a0859529c853ffb756b1deee946923b6fff6136e
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Mar 23 19:30:47 2008 +0100

    Fix Coverity ID 488
    
    "status" was used uninitialized on success -- metze, please check

commit 22cee9c1afbc33b4920b72bc81569d79642172af
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Mar 23 19:26:35 2008 +0100

    Fix Coverity ID 487

-----------------------------------------------------------------------

Summary of changes:
 source/libads/ldap.c             |    1 +
 source/libads/sasl.c             |    2 ++
 source/rpc_parse/parse_spoolss.c |    4 ++--
 source/rpc_server/srv_pipe.c     |    2 ++
 4 files changed, 7 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libads/ldap.c b/source/libads/ldap.c
index 9ec06e5..00d36b7 100644
--- a/source/libads/ldap.c
+++ b/source/libads/ldap.c
@@ -3413,6 +3413,7 @@ ADS_STATUS ads_find_samaccount(ADS_STRUCT *ads,
 	filter = talloc_asprintf(mem_ctx, "(&(objectclass=user)(sAMAccountName=%s))",
 		samaccountname);
 	if (filter == NULL) {
+		status = ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
 		goto out;
 	}
 
diff --git a/source/libads/sasl.c b/source/libads/sasl.c
index 798d0b4..55bc16a 100644
--- a/source/libads/sasl.c
+++ b/source/libads/sasl.c
@@ -597,6 +597,8 @@ static ADS_STATUS ads_sasl_spnego_gsskrb5_bind(ADS_STRUCT *ads, const gss_name_t
 		context_handle = GSS_C_NO_CONTEXT;
 	}
 
+	status = ADS_SUCCESS;
+
 failed:
 	if (context_handle != GSS_C_NO_CONTEXT)
 		gss_delete_sec_context(&minor_status, &context_handle, GSS_C_NO_BUFFER);
diff --git a/source/rpc_parse/parse_spoolss.c b/source/rpc_parse/parse_spoolss.c
index 3bf8ef2..bf7166b 100644
--- a/source/rpc_parse/parse_spoolss.c
+++ b/source/rpc_parse/parse_spoolss.c
@@ -4785,7 +4785,7 @@ bool spoolss_io_q_addprinterex(const char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_
 		if (!sec_io_desc_buf(desc, &q_u->secdesc_ctr, ps, depth))
 			return False;
 	} else {
-		uint32 dummy;
+		uint32 dummy = 0;
 
 		/* Parse a NULL security descriptor.  This should really
 			happen inside the sec_io_desc_buf() function. */
@@ -7205,7 +7205,7 @@ bool make_spoolss_q_getprintprocessordirectory(SPOOL_Q_GETPRINTPROCESSORDIRECTOR
 
 bool spoolss_io_q_getprintprocessordirectory(const char *desc, SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, prs_struct *ps, int depth)
 {
-	uint32 ptr;
+	uint32 ptr = 0;
 
 	prs_debug(ps, depth, desc, "spoolss_io_q_getprintprocessordirectory");
 	depth++;
diff --git a/source/rpc_server/srv_pipe.c b/source/rpc_server/srv_pipe.c
index f33ee88..05cdb65 100644
--- a/source/rpc_server/srv_pipe.c
+++ b/source/rpc_server/srv_pipe.c
@@ -1593,6 +1593,8 @@ bool api_pipe_bind_req(pipes_struct *p, prs_struct *rpc_in_p)
 		}
 	}
 
+	ZERO_STRUCT(hdr_rb);
+
 	/* decode the bind request */
 	if(!smb_io_rpc_hdr_rb("", &hdr_rb, rpc_in_p, 0))  {
 		DEBUG(0,("api_pipe_bind_req: unable to unmarshall RPC_HDR_RB struct.\n"));


-- 
Samba Shared Repository