[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-165-gc240181

Volker Lendecke vlendec at samba.org
Sat Mar 8 22:49:43 GMT 2008


The branch, v3-2-test has been updated
       via  c2401811aa3d02a9e27969687b9ea035407000c3 (commit)
      from  776e21075b31db605e45f91b6ccefd11412d7773 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit c2401811aa3d02a9e27969687b9ea035407000c3
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Mar 8 23:48:12 2008 +0100

    Fix Coverity ID 551
    
    Correctly return if we can't create the temporary krb5.conf
    
    Jeremy, please check!

-----------------------------------------------------------------------

Summary of changes:
 source/libads/kerberos.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libads/kerberos.c b/source/libads/kerberos.c
index b37b9a5..ee25fb5 100644
--- a/source/libads/kerberos.c
+++ b/source/libads/kerberos.c
@@ -894,6 +894,8 @@ bool create_local_private_krb5_conf_for_domain(const char *realm,
 		DEBUG(0,("create_local_private_krb5_conf_for_domain: smb_mkstemp failed,"
 			" for file %s. Errno %s\n",
 			tmpname, strerror(errno) ));
+		TALLOC_FREE(dname);
+		return false;
 	}
 
 	if (fchmod(fd, 0644)==-1) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list