[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-2746-g86cabca

[Günther Deschner]

The branch, v3-2-test has been updated
       via  86cabcad74ac06d888f2a352a2bef3abea1ed85c (commit)
      from  ead849949b1b879e2bc4a6b1f7c3d2df1962170a (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 86cabcad74ac06d888f2a352a2bef3abea1ed85c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Mar 5 16:28:43 2008 +0100

    Fix a memleak -- Coverity ID 222
    (cherry picked from commit a40781bafa3a8f0c7737164bca6cf74b0a452e72)

-----------------------------------------------------------------------

Summary of changes:
 source/passdb/pdb_ldap.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/passdb/pdb_ldap.c b/source/passdb/pdb_ldap.c
index 87a648a..dec9b5b 100644
--- a/source/passdb/pdb_ldap.c
+++ b/source/passdb/pdb_ldap.c
@@ -349,6 +349,7 @@ int ldapsam_search_suffix_by_name(struct ldapsam_privates *ldap_state,
 	filter = talloc_asprintf(talloc_tos(), "(&%s%s)", "(uid=%u)",
 		get_objclass_filter(ldap_state->schema_ver));
 	if (!filter) {
+		SAFE_FREE(escape_user);
 		return LDAP_NO_MEMORY;
 	}
 	/*
@@ -358,10 +359,10 @@ int ldapsam_search_suffix_by_name(struct ldapsam_privates *ldap_state,
 
 	filter = talloc_all_string_sub(talloc_tos(),
 				filter, "%u", escape_user);
+	SAFE_FREE(escape_user);
 	if (!filter) {
 		return LDAP_NO_MEMORY;
 	}
-	SAFE_FREE(escape_user);
 
 	ret = smbldap_search_suffix(ldap_state->smbldap_state,
 			filter, attr, result);


-- 
Samba Shared Repository