[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-2942-gf58b098

[Jeremy Allison]

On Sun, Jun 22, 2008 at 02:42:41PM -0500, Volker Lendecke wrote:
> The branch, v3-3-test has been updated
>        via  f58b098a4172949018e84c4d0c722d6eb9bba514 (commit)
>        via  948607f16112f6529f3a54cd6bbe978e8a600bc8 (commit)
>        via  d031e6d8cabe2dd0b29e90d173d45843e145176a (commit)
>       from  587bd636cb70d09600111ced040adaa55af35d0f (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
> 
> 
> - Log -----------------------------------------------------------------
> commit f58b098a4172949018e84c4d0c722d6eb9bba514
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sun Jun 22 20:33:28 2008 +0200
> 
>     Remove the "exists" parameter from create_msdfs_link
>     
>     Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
>     a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
>     3.2. I only check it into 3.3 as I would like you to look at it first.

Hmmm. How does this *ever* work ? :-). Even in 3.3. the code
in _dfs_Add does :

        status = get_referred_path(ctx, r->in.path, jn,
                        &consumedcnt, &self_ref);
        if(!NT_STATUS_IS_OK(status)) {
                return ntstatus_to_werror(status);
        }

Doesn't look condusive to a create to me :-).

Can we chat about this ?

Jeremy.