[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-2854-gb58e4f6

[Karolin Seeger]

The branch, v3-3-test has been updated
       via  b58e4f6b3d73294d8448c0dff4341183c52e5b7c (commit)
      from  1f86c7a2a19e66948c9b51572d3c078b6e03ef52 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit b58e4f6b3d73294d8448c0dff4341183c52e5b7c
Author: Karolin Seeger <kseeger at samba.org>
Date:   Mon Jun 16 15:21:28 2008 +0200

    winbind cache: Don't create SN cache entries during name-to-sid queries.
    
    Clients can request name-to-sid queries for different combinations of
    upper and lower case names. We don't want to create the reverse caching
    entries for each combination used.
    
    This avoids inconsistent answers on sid-to-name queries.
    
    Please review!
    
    Karolin

-----------------------------------------------------------------------

Summary of changes:
 source/winbindd/winbindd_cache.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/winbindd/winbindd_cache.c b/source/winbindd/winbindd_cache.c
index 6040371..03512b9 100644
--- a/source/winbindd/winbindd_cache.c
+++ b/source/winbindd/winbindd_cache.c
@@ -1451,13 +1451,13 @@ do_query:
 	if (domain->online &&
 	    (NT_STATUS_IS_OK(status) || NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED))) {
 		wcache_save_name_to_sid(domain, status, domain_name, name, sid, *type);
+	
+	/* Don't add SN cache entries for sid-to-name queries during this operation.
+	 * It leads to inconsistent answers during sid-to-name queries as the
+	 * client can ask for different combinations of lower case and upper case
+	 * names in these name-to-sid queries.
+	 */
 
-		/* Only save the reverse mapping if this was not a UPN */
-		if (!strchr(name, '@')) {
-			strupper_m(CONST_DISCARD(char *,domain_name));
-			strlower_m(CONST_DISCARD(char *,name));
-			wcache_save_sid_to_name(domain, status, sid, domain_name, name, *type);
-		}
 	}
 	
 	return status;


-- 
Samba Shared Repository