[SCM] Samba Shared Repository - branch v3-3-test updated -
release-3-2-0pre2-2847-g5663587
Volker Lendecke
vlendec at samba.org
Sat Jun 14 22:23:12 GMT 2008
The branch, v3-3-test has been updated
via 5663587e5e4703f9e3ff6d78d1f3248053ccd4c0 (commit)
from 26c05a52b73763dad5ad0525dab6e20014c3f8d6 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit 5663587e5e4703f9e3ff6d78d1f3248053ccd4c0
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jun 15 00:22:47 2008 +0200
Fix an uninitialized variable found by the IBM checker
BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.
Stefan, please check!
Volker
(cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)
-----------------------------------------------------------------------
Summary of changes:
source/nsswitch/libwbclient/wbc_pwd.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/nsswitch/libwbclient/wbc_pwd.c b/source/nsswitch/libwbclient/wbc_pwd.c
index d23c378..b5f1673 100644
--- a/source/nsswitch/libwbclient/wbc_pwd.c
+++ b/source/nsswitch/libwbclient/wbc_pwd.c
@@ -394,16 +394,16 @@ wbcErr wbcGetGroups(const char *account,
uint32_t i;
gid_t *groups = NULL;
- if (!account) {
- wbc_status = WBC_ERR_INVALID_PARAM;
- BAIL_ON_WBC_ERROR(wbc_status);
- }
-
/* Initialize request */
ZERO_STRUCT(request);
ZERO_STRUCT(response);
+ if (!account) {
+ wbc_status = WBC_ERR_INVALID_PARAM;
+ BAIL_ON_WBC_ERROR(wbc_status);
+ }
+
/* Send request */
strncpy(request.data.username, account, sizeof(request.data.username)-1);
--
Samba Shared Repository
More information about the samba-cvs
mailing list