[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2568-g999533c

[Volker Lendecke]

The branch, v3-2-test has been updated
       via  999533c0ccced59141d8baff5bc248d63e2a966f (commit)
      from  1a22e975dd1255f3557c1cd873d877aa35822afc (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 999533c0ccced59141d8baff5bc248d63e2a966f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jun 13 15:30:08 2008 +0200

    Fix a crash in _winreg_QueryValue
    
    Coverity ID 474, value_length and type are both unique, not ref pointers and
    can thus be NULL.
    
    Karolin, please merge this to -stable.
    
    Thanks,
    
    Volker

-----------------------------------------------------------------------

Summary of changes:
 source/rpc_server/srv_winreg_nt.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/rpc_server/srv_winreg_nt.c b/source/rpc_server/srv_winreg_nt.c
index 7b74871..84bcf0b 100644
--- a/source/rpc_server/srv_winreg_nt.c
+++ b/source/rpc_server/srv_winreg_nt.c
@@ -230,6 +230,10 @@ WERROR _winreg_QueryValue(pipes_struct *p, struct winreg_QueryValue *r)
 	if ( !regkey )
 		return WERR_BADFID;
 
+	if ((r->out.value_length == NULL) || (r->out.type == NULL)) {
+		return WERR_INVALID_PARAM;
+	}
+
 	*r->out.value_length = *r->out.type = REG_NONE;
 	
 	DEBUG(7,("_reg_info: policy key name = [%s]\n", regkey->key->name));


-- 
Samba Shared Repository