[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-29-21-g89b771e

Volker Lendecke vlendec at samba.org
Mon Jun 2 12:54:54 GMT 2008


The branch, v3-0-test has been updated
       via  89b771ea2dc90e3017f1aa26f352afce9d0c0b65 (commit)
      from  c31b83d503289a4ec337c128d63adfcb32087fbe (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test


- Log -----------------------------------------------------------------
commit 89b771ea2dc90e3017f1aa26f352afce9d0c0b65
Author: Günther Deschner <gd at samba.org>
Date:   Sat Mar 29 00:47:42 2008 +0100

    Don't let winbind getgroups crash when we have no gids in the token.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source/nsswitch/winbindd_group.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/nsswitch/winbindd_group.c b/source/nsswitch/winbindd_group.c
index c7baecf..cc8bfb0 100644
--- a/source/nsswitch/winbindd_group.c
+++ b/source/nsswitch/winbindd_group.c
@@ -1398,8 +1398,11 @@ static void getgroups_sid2gid_recv(void *private_data, BOOL success, gid_t gid)
 
 	s->state->response.data.num_entries = s->num_token_gids;
 	/* s->token_gids are talloced */
-	s->state->response.extra_data.data = smb_xmemdup(s->token_gids, s->num_token_gids * sizeof(gid_t));
-	s->state->response.length += s->num_token_gids * sizeof(gid_t);
+	if (s->num_token_gids != 0) {
+		s->state->response.extra_data.data = smb_xmemdup(
+			s->token_gids, s->num_token_gids * sizeof(gid_t));
+		s->state->response.length += s->num_token_gids * sizeof(gid_t);
+	}
 	request_ok(s->state);
 }
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list