[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3405-g9e49d39

Volker Lendecke vlendec at samba.org
Thu Jul 24 12:48:21 GMT 2008


The branch, v3-3-test has been updated
       via  9e49d390f79c6afc8b0efd9664e60602aebaa4f2 (commit)
      from  9b863a10da8762f715c16f147d6cd1e79422d248 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 9e49d390f79c6afc8b0efd9664e60602aebaa4f2
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 24 14:46:43 2008 +0200

    Make use of TALLOC_FREE when freeing the per-winbindrequest memory context

-----------------------------------------------------------------------

Summary of changes:
 source/winbindd/winbindd.c |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/winbindd/winbindd.c b/source/winbindd/winbindd.c
index 55ab58f..cb16c76 100644
--- a/source/winbindd/winbindd.c
+++ b/source/winbindd/winbindd.c
@@ -546,10 +546,7 @@ static void response_extra_sent(void *private_data, bool success)
 	struct winbindd_cli_state *state =
 		talloc_get_type_abort(private_data, struct winbindd_cli_state);
 
-	if (state->mem_ctx != NULL) {
-		talloc_destroy(state->mem_ctx);
-		state->mem_ctx = NULL;
-	}
+	TALLOC_FREE(state->mem_ctx);
 
 	if (!success) {
 		state->finished = True;
@@ -574,10 +571,7 @@ static void response_main_sent(void *private_data, bool success)
 	}
 
 	if (state->response.length == sizeof(state->response)) {
-		if (state->mem_ctx != NULL) {
-			talloc_destroy(state->mem_ctx);
-			state->mem_ctx = NULL;
-		}
+		TALLOC_FREE(state->mem_ctx);
 
 		setup_async_read(&state->fd_event, &state->request,
 				 sizeof(uint32), request_len_recv, state);
@@ -767,10 +761,7 @@ static void remove_client(struct winbindd_cli_state *state)
 
 	SAFE_FREE(state->response.extra_data.data);
 
-	if (state->mem_ctx != NULL) {
-		talloc_destroy(state->mem_ctx);
-		state->mem_ctx = NULL;
-	}
+	TALLOC_FREE(state->mem_ctx);
 
 	remove_fd_event(&state->fd_event);
 		


-- 
Samba Shared Repository


More information about the samba-cvs mailing list