[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3052-g534a445

[Karolin Seeger]

The branch, v3-3-test has been updated
       via  534a445df450c681be7da2c9dd65f7294f942b08 (commit)
      from  0ef420c3a478a8adce7483f14b45e9995bfa5e5d (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -----------------------------------------------------------------
commit 534a445df450c681be7da2c9dd65f7294f942b08
Author: Karolin Seeger <kseeger at samba.org>
Date:   Tue Jul 1 10:34:22 2008 +0200

    Revert "winbind cache: Don't create SN cache entries during name-to-sid queries."
    
    This reverts commit b58e4f6b3d73294d8448c0dff4341183c52e5b7c.
    
    Details can be found on the samba-technical mailing list.
    
    Karolin

-----------------------------------------------------------------------

Summary of changes:
 source/winbindd/winbindd_cache.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/winbindd/winbindd_cache.c b/source/winbindd/winbindd_cache.c
index 03512b9..6040371 100644
--- a/source/winbindd/winbindd_cache.c
+++ b/source/winbindd/winbindd_cache.c
@@ -1451,13 +1451,13 @@ do_query:
 	if (domain->online &&
 	    (NT_STATUS_IS_OK(status) || NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED))) {
 		wcache_save_name_to_sid(domain, status, domain_name, name, sid, *type);
-	
-	/* Don't add SN cache entries for sid-to-name queries during this operation.
-	 * It leads to inconsistent answers during sid-to-name queries as the
-	 * client can ask for different combinations of lower case and upper case
-	 * names in these name-to-sid queries.
-	 */
 
+		/* Only save the reverse mapping if this was not a UPN */
+		if (!strchr(name, '@')) {
+			strupper_m(CONST_DISCARD(char *,domain_name));
+			strlower_m(CONST_DISCARD(char *,name));
+			wcache_save_sid_to_name(domain, status, sid, domain_name, name, *type);
+		}
 	}
 	
 	return status;


-- 
Samba Shared Repository