[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-1619-gda131d0

Michael Adam obnox at samba.org
Wed Jan 23 13:48:10 GMT 2008


The branch, v3-2-test has been updated
       via  da131d089db98017632103aa9bbe38c98f7a3fc1 (commit)
       via  1f49065d44dd7570d5a9928359751bd36f287952 (commit)
      from  9cf3a98eacea2dd07f89245f147e002b3f49482e (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit da131d089db98017632103aa9bbe38c98f7a3fc1
Author: Michael Adam <obnox at samba.org>
Date:   Wed Jan 23 14:33:22 2008 +0100

    Fix panic: Don't free the logfilename in winbind_child_died().
    
    The child struct is immediately reused, and this results
    in a panic when child->logfilename == NULL.
    
    Michael

commit 1f49065d44dd7570d5a9928359751bd36f287952
Author: Michael Adam <obnox at samba.org>
Date:   Wed Jan 23 13:52:42 2008 +0100

    Initialize _domain_list to NULL.
    
    Just to be sure the "if (!_domain_list)" in domain_list() test always works.
    
    Michael

-----------------------------------------------------------------------

Summary of changes:
 source/winbindd/winbindd_dual.c |    1 -
 source/winbindd/winbindd_util.c |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/winbindd/winbindd_dual.c b/source/winbindd/winbindd_dual.c
index 778886d..e215246 100644
--- a/source/winbindd/winbindd_dual.c
+++ b/source/winbindd/winbindd_dual.c
@@ -480,7 +480,6 @@ void winbind_child_died(pid_t pid)
 	child->event.fd = 0;
 	child->event.flags = 0;
 	child->pid = 0;
-	SAFE_FREE(child->logfilename);
 
 	schedule_async_request(child);
 }
diff --git a/source/winbindd/winbindd_util.c b/source/winbindd/winbindd_util.c
index dc48fde..0381053 100644
--- a/source/winbindd/winbindd_util.c
+++ b/source/winbindd/winbindd_util.c
@@ -41,7 +41,7 @@ extern struct winbindd_methods passdb_methods;
    individual winbindd_domain structures cannot be made.  Keep a copy of
    the domain name instead. */
 
-static struct winbindd_domain *_domain_list;
+static struct winbindd_domain *_domain_list = NULL;
 
 /**
    When was the last scan of trusted domains done?


-- 
Samba Shared Repository


More information about the samba-cvs mailing list