[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-1605-g8cf8c5b

Volker Lendecke vl at samba.org
Tue Jan 22 08:34:59 GMT 2008


The branch, v3-2-test has been updated
       via  8cf8c5b2034fe093b5db7f069bc6be8d328399bf (commit)
       via  8741a9b37496e78b28d59d844aaba12f269171e0 (commit)
      from  c8def5564739c4c754001f84fcfb77f1093b96c3 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 8cf8c5b2034fe093b5db7f069bc6be8d328399bf
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 22 09:22:14 2008 +0100

    Fix a ton of IBM checker uninitialized variable warnings
    
    SET_STAT_INVALID only sets nlink, not the other fields
    
    We might consider to change SET_STAT_INVALID to always do ZERO_STRUCT

commit 8741a9b37496e78b28d59d844aaba12f269171e0
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 22 09:18:40 2008 +0100

    Fix get_ea_names_from_file for many EAs
    
    Found by the IBM checker

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/open.c   |    3 +--
 source/smbd/trans2.c |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/open.c b/source/smbd/open.c
index 9fca38e..aa4bc48 100644
--- a/source/smbd/open.c
+++ b/source/smbd/open.c
@@ -3034,8 +3034,7 @@ NTSTATUS create_file(connection_struct *conn,
 				goto fail;
 			}
 
-			SET_STAT_INVALID(sbuf);
-
+			ZERO_STRUCT(sbuf);
 			goto done;
 		}
 	}
diff --git a/source/smbd/trans2.c b/source/smbd/trans2.c
index 9c48cdf..896d2de 100644
--- a/source/smbd/trans2.c
+++ b/source/smbd/trans2.c
@@ -210,7 +210,7 @@ NTSTATUS get_ea_names_from_file(TALLOC_CTX *mem_ctx, connection_struct *conn,
 						    ea_namelist_size);
 		}
 
-		if ((sizeret == -1) && (errno = ERANGE)) {
+		if ((sizeret == -1) && (errno == ERANGE)) {
 			ea_namelist_size *= 2;
 		}
 		else {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list